git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 05/14] clear_ref_array(): rename from free_ref_array()

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Oct 17, 2011, 07:39 UTC
Message-ID
<1318837163-27112-6-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1318837163-27112-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

Rename the function since it doesn't actually free the array object that is passed to it.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/refs.c b/refs.c
index 87c8913..30e505a 100644
--- a/refs.c
+++ b/refs.c
@@ -149,7 +149,7 @@ static struct ref_entry *current_ref;
 
 static struct ref_array extra_refs;
 
-static void free_ref_array(struct ref_array *array)
+static void clear_ref_array(struct ref_array *array)
 {
 	int i;
 	for (i = 0; i < array->nr; i++)
@@ -162,14 +162,14 @@ static void free_ref_array(struct ref_array *array)
 static void clear_packed_ref_cache(struct ref_cache *refs)
 {
 	if (refs->did_packed)
-		free_ref_array(&refs->packed);
+		clear_ref_array(&refs->packed);
 	refs->did_packed = 0;
 }
 
 static void clear_loose_ref_cache(struct ref_cache *refs)
 {
 	if (refs->did_loose)
-		free_ref_array(&refs->loose);
+		clear_ref_array(&refs->loose);
 	refs->did_loose = 0;
 }
 
@@ -256,7 +256,7 @@ void add_extra_ref(const char *refname, const unsigned char *sha1, int flag)
 
 void clear_extra_refs(void)
 {
-	free_ref_array(&extra_refs);
+	clear_ref_array(&extra_refs);
 }
 
 static struct ref_array *get_packed_refs(const char *submodule)

-- 
1.7.7.rc2
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 6 of 16 in “Tidying up references code”
  1. 00/14 Tidying up references codemhagger@alum.mit.edu, Oct 17, 2011
  2. 01/14 cache.h: add comments for git_path() and git_path_submodule()mhagger@alum.mit.edu, Oct 17, 2011
  3. 02/14 struct ref_entry: document name membermhagger@alum.mit.edu, Oct 17, 2011
  4. 03/14 refs: rename "refname" variablesmhagger@alum.mit.edu, Oct 17, 2011
  5. 04/14 refs: rename parameters result -> sha1mhagger@alum.mit.edu, Oct 17, 2011
  6. 05/14 clear_ref_array(): rename from free_ref_array()mhagger@alum.mit.edu, Oct 17, 2011
  7. 06/14 is_refname_available(): remove the "quiet" argumentmhagger@alum.mit.edu, Oct 17, 2011
  8. 07/14 parse_ref_line(): add docstringmhagger@alum.mit.edu, Oct 17, 2011
  9. 08/14 add_ref(): add docstringmhagger@alum.mit.edu, Oct 17, 2011
  10. 09/14 is_dup_ref(): extract function from sort_ref_array()mhagger@alum.mit.edu, Oct 17, 2011
  11. 10/14 refs: change signatures of get_packed_refs() and get_loose_refs()mhagger@alum.mit.edu, Oct 17, 2011
  12. 11/14 get_ref_dir(): change signaturemhagger@alum.mit.edu, Oct 17, 2011
  13. 12/14 resolve_gitlink_ref(): improve docstringmhagger@alum.mit.edu, Oct 17, 2011
  14. 13/14 Pass a (ref_cache *) to the resolve_gitlink_*() helper functionsmhagger@alum.mit.edu, Oct 17, 2011
  15. 14/14 resolve_gitlink_ref_recursive(): change to work with struct ref_cachemhagger@alum.mit.edu, Oct 17, 2011
  16. Junio C HamanoOct 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.