git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] t9300: do not run --cat-blob-fd related tests on MinGW

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Oct 15, 2011, 14:05 UTC
Message-ID
<1318687520-19522-6-git-send-email-patthoyts@users.sourceforge.net>
In-Reply-To
<1318687520-19522-1-git-send-email-patthoyts@users.sourceforge.net>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

As diagnosed by Johannes Sixt, msys.dll does not hand through file descriptors > 2 to child processes, so these test cases cannot passes when run through an MSys bash.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9300-fast-import.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index bd32b91..438aaf6 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -2237,7 +2237,7 @@ test_expect_success 'R: cat-blob-fd must be a nonnegative integer' '
 	test_must_fail git fast-import --cat-blob-fd=-1 </dev/null
 '
 
-test_expect_success 'R: print old blob' '
+test_expect_success NOT_MINGW 'R: print old blob' '
 	blob=$(echo "yes it can" | git hash-object -w --stdin) &&
 	cat >expect <<-EOF &&
 	${blob} blob 11
@@ -2249,7 +2249,7 @@ test_expect_success 'R: print old blob' '
 	test_cmp expect actual
 '
 
-test_expect_success 'R: in-stream cat-blob-fd not respected' '
+test_expect_success NOT_MINGW 'R: in-stream cat-blob-fd not respected' '
 	echo hello >greeting &&
 	blob=$(git hash-object -w greeting) &&
 	cat >expect <<-EOF &&
@@ -2270,7 +2270,7 @@ test_expect_success 'R: in-stream cat-blob-fd not respected' '
 	test_cmp expect actual.1
 '
 
-test_expect_success 'R: print new blob' '
+test_expect_success NOT_MINGW 'R: print new blob' '
 	blob=$(echo "yep yep yep" | git hash-object --stdin) &&
 	cat >expect <<-EOF &&
 	${blob} blob 12
@@ -2288,7 +2288,7 @@ test_expect_success 'R: print new blob' '
 	test_cmp expect actual
 '
 
-test_expect_success 'R: print new blob by sha1' '
+test_expect_success NOT_MINGW 'R: print new blob by sha1' '
 	blob=$(echo "a new blob named by sha1" | git hash-object --stdin) &&
 	cat >expect <<-EOF &&
 	${blob} blob 25
-- 
1.7.7.1.gbba15
Previous: Pat ThoytsNext: Pat Thoyts
Message 6 of 9 in “Some patches from msysGit (round 2)”
  1. 0/7 Some patches from msysGit (round 2)Pat Thoyts, Oct 15, 2011
  2. 1/7 t1020: disable the pwd test on MinGWPat Thoyts, Oct 15, 2011
  3. 2/7 t9001: do not fail only due to CR/LF issuesPat Thoyts, Oct 15, 2011
  4. 3/7 git-svn: On MSYS, escape and quote SVN_SSH also if set by the userPat Thoyts, Oct 15, 2011
  5. 4/7 t9901: fix line-ending dependency on windowsPat Thoyts, Oct 15, 2011
  6. 5/7 t9300: do not run --cat-blob-fd related tests on MinGWPat Thoyts, Oct 15, 2011
  7. 6/7 mergetools: use the correct tool for Beyond Compare 3 on WindowsPat Thoyts, Oct 15, 2011
  8. 7/7 mingw: ensure sockets are initialized before calling gethostnamePat Thoyts, Oct 15, 2011
  9. Junio C HamanoOct 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.