[PATCH] send-email: Honour SMTP domain when using TLS
- From
- Matthew Daley <mattjd@gmail.com>
- Date
- Oct 15, 2011, 08:44 UTC
- Message-ID
- <1318668292-13818-1-git-send-email-mattjd@gmail.com>
git-send-email sends two SMTP EHLOs when using TLS encryption, however only the first, unencrypted EHLO uses the SMTP domain that can be optionally specified by the user (--smtp-domain). This is because the call to hello() that produces the second, encrypted EHLO does not pass the SMTP domain as an argument, and hence a default of 'localhost.localdomain' is used instead.
Fix by passing in the SMTP domain in this call.
Signed-off-by: Matthew Daley <mattjd@gmail.com> --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 6885dfa..d491db9 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1098,7 +1098,7 @@ X-Mailer: git-send-email $gitversion $smtp_encryption = ''; # Send EHLO again to receive fresh # supported commands - $smtp->hello(); + $smtp->hello($smtp_domain); } else { die "Server does not support STARTTLS! ".$smtp->message; }
-- 1.7.2.5