[PATCH v3 11/22] resolve_ref(): use prefixcmp()

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sep 15, 2011, 21:10 UTC
Message-ID: <1316121043-29367-12-git-send-email-mhagger@alum.mit.edu>
In-Reply-To: <1316121043-29367-1-git-send-email-mhagger@alum.mit.edu>

Terminate the link content string one step earlier, allowing prefixcmp() to be used instead of the less clear memcmp().

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 refs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index c51fd45..da9737f 100644
--- a/refs.c
+++ b/refs.c
@@ -520,8 +520,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
 			len = readlink(path, buffer, sizeof(buffer)-1);
 			if (len < 0)
 				return NULL;
-			if (len >= 5 && !memcmp("refs/", buffer, 5)) {
-				buffer[len] = 0;
+			buffer[len] = 0;
+			if (!prefixcmp(buffer, "refs/")) {
 				strcpy(ref_buffer, buffer);
 				ref = ref_buffer;
 				if (flag)

-- 
1.7.6.8.gd2879