git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Un-static gitmkstemps

From
Brian Gernhardt <brian@gernhardtsoftware.com>
Date
Sep 15, 2011, 12:21 UTC
Message-ID
<1316089260-76049-1-git-send-email-brian@gernhardtsoftware.com>

It may not be used in most builds, but it's used via a #ifdef in git-compat-util.h Also, making it static makes a -Wall compile fail since it's not used in the file without NO_MKSTEMPS.

Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---
 Either this, or it should be removed from git-compat-util and wrapped in
 an #ifdef.  (The only current user is git_mkstemps), but since it's
 referenced in a header file, I figured it shouldn't be static.
 wrapper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/wrapper.c b/wrapper.c
index 390a7ae..1c41488 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -310,7 +310,7 @@ int git_mkstemp_mode(char *pattern, int mode)
 	return git_mkstemps_mode(pattern, 0, mode);
 }
 
-static int gitmkstemps(char *pattern, int suffix_len)
+int gitmkstemps(char *pattern, int suffix_len)
 {
 	return git_mkstemps_mode(pattern, suffix_len, 0600);
 }
-- 
1.7.7.rc0.309.g13ed2.dirty
Next: Junio C Hamano
Message 1 of 2 in “Un-static gitmkstemps”
  1. Un-static gitmkstempsBrian Gernhardt, Sep 15, 2011
  2. Junio C HamanoSep 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.