git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFCv2 0/2] format-patch: produce non colorized patches when color.ui=always

From
Pang Yan Han <pangyanhan@gmail.com>
Date
Sep 12, 2011, 17:46 UTC
Message-ID
<1315849601-26497-1-git-send-email-pangyanhan@gmail.com>
Hi list,
This 2-patch series has been rerolled with Jeff's suggestions.

For patch 1/2, I've renamed the new test file to t4051-format-patch-config.sh and changed the description to "check that format-patch does not respect porcelain config". In addition, I've slightly reworded the commit message to include the date of the commit (c9bfb953) which introduces the regression.

For patch 2/2, as per Jeff's recommendation, teach git_format_config to intercept color.ui in the same way as commit f3aafa4 (Disable color detection during format-patch, 2006-07-09). This is inline with the way we avoid passing down diff.color and color.diff to git_log_config and config functions further down the callchain.

Pang Yan Han (2):
  format-patch: demonstrate that color.ui=always produces colorized
    patches
  format-patch: produce non colorized patches when ui.color=always
 builtin/log.c                  |    3 ++-
 t/t4051-format-patch-config.sh |   23 +++++++++++++++++++++++
 2 files changed, 25 insertions(+), 1 deletions(-)
 create mode 100755 t/t4051-format-patch-config.sh
-- 
1.7.7.rc0.190.gb47b6
Next: Pang Yan Han
Message 1 of 6 in “format-patch: produce non colorized patches when color.ui=always”
  1. 0/2 format-patch: produce non colorized patches when color.ui=alwaysPang Yan Han, Sep 12, 2011
  2. 1/2 format-patch: demonstrate that color.ui=always produces colorized patchesPang Yan Han, Sep 12, 2011
  3. Junio C HamanoSep 12, 2011
  4. 2/2 format-patch: produce non colorized patches when ui.color=alwaysPang Yan Han, Sep 12, 2011
  5. Junio C HamanoSep 12, 2011
  6. Junio C HamanoSep 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.