git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] rev-list: fix finish_object() call

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 17, 2011, 21:30 UTC
Message-ID
<1313616635-25331-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1313616635-25331-1-git-send-email-gitster@pobox.com>

The callback to traverse_commit_list() are to take linked name_path and a string for the last path component.

If the callee used its parameters, it would have seen duplicated leading paths. In this particular case, the callee does not use this argument but that is not a reason to leave the call broken.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/rev-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index 56727e8..d789279 100644
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -182,7 +182,7 @@ static void show_object(struct object *obj, const struct name_path *path, const
 	 */
 	const char *ep = strchr(name, '\n');
 
-	finish_object(obj, path, name);
+	finish_object(obj, path, component);
 	if (ep) {
 		printf("%s %.*s\n", sha1_to_hex(obj->sha1),
 		       (int) (ep - name),
-- 
1.7.6.472.g4bfe7c
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 4 in “Minor "list-objects" updates”
  1. 0/3 Minor "list-objects" updatesJunio C Hamano, Aug 17, 2011
  2. 1/3 rev-list: fix finish_object() callJunio C Hamano, Aug 17, 2011
  3. 2/3 revision.c: add show_object_with_name() helper functionJunio C Hamano, Aug 17, 2011
  4. 3/3 revision.c: update show_object_with_name() without using malloc()Junio C Hamano, Aug 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.