git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] Add a file comment

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Aug 12, 2011, 21:43 UTC
Message-ID
<1313185390-19724-2-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1313185390-19724-1-git-send-email-mhagger@alum.mit.edu>

Consolidate here a few general comments plus links to other documentation. Delete a comment with an out-of-date description of the .gitattributes file format.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 attr.c |   26 ++++++++++----------------
 1 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/attr.c b/attr.c
index f6b3f7e..6bc7ae9 100644
--- a/attr.c
+++ b/attr.c
@@ -1,3 +1,12 @@
+/*
+ * Handle git attributes.  See gitattributes(5) for a description of
+ * the file syntax, and Documentation/technical/api-gitattributes.txt
+ * for a description of the API.
+ *
+ * One basic design decision here is that we are not going to support
+ * an insanely large number of attributes.
+ */
+
 #define NO_THE_INDEX_COMPATIBILITY_MACROS
 #include "cache.h"
 #include "exec_cmd.h"
@@ -13,12 +22,7 @@ static const char git_attr__unknown[] = "(builtin)unknown";
 
 static const char *attributes_file;
 
-/*
- * The basic design decision here is that we are not going to have
- * insanely large number of attributes.
- *
- * This is a randomly chosen prime.
- */
+/* This is a randomly chosen prime. */
 #define HASHSIZE 257
 
 #ifndef DEBUG_ATTR
@@ -103,16 +107,6 @@ struct git_attr *git_attr(const char *name)
 	return git_attr_internal(name, strlen(name));
 }
 
-/*
- * .gitattributes file is one line per record, each of which is
- *
- * (1) glob pattern.
- * (2) whitespace
- * (3) whitespace separated list of attribute names, each of which
- *     could be prefixed with '-' to mean "set to false", '!' to mean
- *     "unset".
- */
-
 /* What does a matched pattern decide? */
 struct attr_state {
 	struct git_attr *attr;
-- 
1.7.6.8.gd2879
Previous: Michael HaggertyNext: Michael Haggerty
Message 2 of 8 in “Comments and refactoring in attr.c”
  1. 0/7 Comments and refactoring in attr.cMichael Haggerty, Aug 12, 2011
  2. 1/7 Add a file commentMichael Haggerty, Aug 12, 2011
  3. 2/7 Document struct match_attrMichael Haggerty, Aug 12, 2011
  4. 3/7 Increment num_attr in parse_attr_line(), not parse_attr()Michael Haggerty, Aug 12, 2011
  5. 4/7 Change parse_attr() to take a pointer to struct attr_stateMichael Haggerty, Aug 12, 2011
  6. 5/7 Determine the start of the states outside of the pass loopMichael Haggerty, Aug 12, 2011
  7. 6/7 Change while loop into for loopMichael Haggerty, Aug 12, 2011
  8. 7/7 Unroll the loop over passesMichael Haggerty, Aug 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.