[RFC/PATCH 6/6] gitweb: Highlight matched part of project description when searching projects
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jul 29, 2011, 11:52 UTC
- Message-ID
- <1311940379-9608-7-git-send-email-jnareb@gmail.com>
- In-Reply-To
- <1311940379-9608-1-git-send-email-jnareb@gmail.com>
Use esc_html_match_hl() from previous commit to mark match in the _whole_ description when searching projects.
Currently, with this commit, when searching projects there is always shown full description of a project, and not a shortened one (like for ordinary projects list view), even if the match is on project name and not project description.
Showing full description when there is match on it is useful to avoid situation where match is in shortened, invisible part... well, perhaps that could be solved (showing shortened description), but it would require much more complicated code.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This is slightly controversial part.
Note: some of changes is just reindent.
gitweb/gitweb.perl | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 692a6bb..6bc68c5 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5172,7 +5172,10 @@ sub git_project_list_rows { "</td>\n" . "<td>" . $cgi->a({-href => href(project=>$pr->{'path'}, action=>"summary"), -class => "list", -title => $pr->{'descr_long'}}, - esc_html($pr->{'descr'})) . "</td>\n" . + $search_regexp + ? esc_html_match_hl($pr->{'descr_long'}, $search_regexp) + : esc_html($pr->{'descr'})) . + "</td>\n" . "<td><i>" . chop_and_escape_str($pr->{'owner'}, 15) . "</i></td>\n"; print "<td class=\"". age_class($pr->{'age'}) . "\">" . (defined $pr->{'age_string'} ? $pr->{'age_string'} : "No commits") . "</td>\n" .
-- 1.7.5