[PATCHv3 1/5] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 22, 2011, 15:28 UTC
- Message-ID
- <1308756535-29701-2-git-send-email-jnareb@gmail.com>
- In-Reply-To
- <1308756535-29701-1-git-send-email-jnareb@gmail.com>
Both 'pickaxe' (searching changes) and 'grep' (searching files) require basic 'search' feature to be enabled to work. Enabling e.g. only 'pickaxe' won't work.
Add a comment about this.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This is slightly more expanded version than what was sent to git mailing list as
[PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled http://thread.gmane.org/gmane.comp.version-control.git/176095/focus=176127
What's new is comment for 'search' feature.
gitweb/gitweb.perl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 0221eb9..fd93d45 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -321,6 +321,10 @@ our %feature = ( # Enable text search, which will list the commits which match author, # committer or commit text to a given string. Enabled by default. # Project specific override is not supported. + # + # Note that this controls all search features, which means that if + # it is disabled, then 'grep' and 'pickaxe' search would also be + # disabled. 'search' => { 'override' => 0, 'default' => [1]}, @@ -328,6 +332,7 @@ our %feature = ( # Enable grep search, which will list the files in currently selected # tree containing the given string. Enabled by default. This can be # potentially CPU-intensive, of course. + # Note that you need to have 'search' feature enabled too. # To enable system wide have in $GITWEB_CONFIG # $feature{'grep'}{'default'} = [1]; @@ -342,6 +347,7 @@ our %feature = ( # Enable the pickaxe search, which will list the commits that modified # a given string in a file. This can be practical and quite faster # alternative to 'blame', but still potentially CPU-intensive. + # Note that you need to have 'search' feature enabled too. # To enable system wide have in $GITWEB_CONFIG # $feature{'pickaxe'}{'default'} = [1];
-- 1.7.5