Re: What's cooking in git.git (Jun 2011, #01; Sun, 5)

From: Jamey Sharp <jamey@minilop.net>
Date: Jun 7, 2011, 18:21 UTC
Message-ID: <1307470885-4018-1-git-send-email-jamey@minilop.net>
In-Reply-To: <7vsjrna2x2.fsf@alter.siamese.dyndns.org>

On Sun, Jun 05, 2011 at 11:29:13PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> * js/ref-namespaces (2011-06-05) 4 commits
>  - ref namespaces: documentation
>  - ref namespaces: support remote repositories via upload-pack and receive-pack
>  - ref namespaces: infrastructure
>  - Fix prefix handling in ref iteration functions
> 
> Fairly involved feature enhancement, and breaks tests when merged to 'pu'.
> Not urgent. Will not merge before 1.7.6.

We tracked down the test failure. t5501 detects that pushing into a repository with an alternate fails to make use of the alternate to avoid extra objects. This failure occurs with the first patch in the series, "Fix prefix handling in ref iteration functions". We added some debugging code which revealed the cause:

DEBUG: Ignoring ref ".have" due to base "refs/"

So, the suggested change to actually use "refs/" as a filter caused this failure. Based on this, we'd tend to suggest that we should go back to the version which preserved the existing behavior, to avoid breaking assumptions like this; that seems preferable to tracking down all the places that would break due to this new ref filtering. Adding that filtering and fixing all the resulting breakage seems like an entirely separate change.

This patch series takes that approach.

Josh Triplett and Jamey Sharp (4):
  Fix prefix handling in ref iteration functions
  Add infrastructure for ref namespaces
  Support ref namespaces for remote repositories via upload-pack and
    receive-pack
  Add documentation for ref namespaces

 Documentation/Makefile                 |    2 +-
 Documentation/git-http-backend.txt     |    8 +++
 Documentation/git-receive-pack.txt     |    2 +-
 Documentation/git-upload-pack.txt      |    4 ++
 Documentation/git.txt                  |   13 +++++-
 Documentation/gitnamespaces.txt        |   75 ++++++++++++++++++++++++++++++++
 builtin/receive-pack.c                 |   34 ++++++++++++---
 cache.h                                |    3 +
 contrib/completion/git-completion.bash |    3 +-
 environment.c                          |   41 +++++++++++++++++
 git.c                                  |   18 +++++++-
 refs.c                                 |   33 ++++++++++++--
 refs.h                                 |    3 +
 upload-pack.c                          |   15 +++---
 14 files changed, 230 insertions(+), 24 deletions(-)
 create mode 100644 Documentation/gitnamespaces.txt

-- 
1.7.5.3