git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] commit: use generic sha1_pos()

From
FBFelipe Balbi <balbi@ti.com>
Date
Jun 1, 2011, 13:20 UTC
Message-ID
<1306934416-4205-1-git-send-email-balbi@ti.com>

instead of reimplementing the binary search, use the generic sha1_pos().

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 commit.c |   25 ++++++++++---------------
 1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/commit.c b/commit.c
index ac337c7..ee8788f 100644
--- a/commit.c
+++ b/commit.c
@@ -6,6 +6,7 @@
 #include "diff.h"
 #include "revision.h"
 #include "notes.h"
+#include "sha1-lookup.h"
 
 int save_commit_buffer = 1;
 
@@ -92,23 +93,17 @@ static unsigned long parse_commit_date(const char *buf, const char *tail)
 static struct commit_graft **commit_graft;
 static int commit_graft_alloc, commit_graft_nr;
 
+static const unsigned char *commit_graft_access(size_t index, void *table)
+{
+	struct commit_graft **graft = table;
+
+	return graft[index]->sha1;
+}
+
 static int commit_graft_pos(const unsigned char *sha1)
 {
-	int lo, hi;
-	lo = 0;
-	hi = commit_graft_nr;
-	while (lo < hi) {
-		int mi = (lo + hi) / 2;
-		struct commit_graft *graft = commit_graft[mi];
-		int cmp = hashcmp(sha1, graft->sha1);
-		if (!cmp)
-			return mi;
-		if (cmp < 0)
-			hi = mi;
-		else
-			lo = mi + 1;
-	}
-	return -lo - 1;
+	return sha1_pos(sha1, commit_graft, commit_graft_nr,
+			commit_graft_access);
 }
 
 int register_commit_graft(struct commit_graft *graft, int ignore_dups)
-- 
1.7.5.1.300.gc565c
Message 1 of 1 in “commit: use generic sha1_pos()”
  1. commit: use generic sha1_pos()Felipe Balbi, Jun 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.