git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] test-svn-fe: split off "test-svn-fe -d" into a separate function

From
Drew Northup <drew.northup@maine.edu>
Date
May 31, 2011, 16:18 UTC
Message-ID
<1306858704.13283.2.camel@drew-northup.unet.maine.edu>
In-Reply-To
<20110527110914.GB7972@elie>
On Fri, 2011-05-27 at 06:09 -0500, Jonathan Nieder wrote:
Show 6 quoted lines
> The helper for testing the svndiff library is getting dangerously
> close to the right margin.  Split it off into a separate function so
> it is easier to contemplate on its own.
> 
> In other words, this just unindents the code a little.  No functional
> change intended.
>  
> +static const char test_svnfe_usage[] =
> +	"test-svn-fe (<dumpfile> | [-d] <preimage> <delta> <len>)";
>  int main(int argc, char *argv[])
>  {
> -	static const char test_svnfe_usage[] =
> -		"test-svn-fe (<dumpfile> | [-d] <preimage> <delta> <len>)";

How is this germane to the original intent? Is there a gain by making it global (to that file) that I'm missing?

-- 
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
Previous: Jonathan NiederNext: Jonathan Nieder
Message 3 of 7 in “vcs-svn: avoid hangs for corrupt deltas”
  1. 0/4 vcs-svn: avoid hangs for corrupt deltasJonathan Nieder, May 27, 2011
  2. 1/4 test-svn-fe: split off "test-svn-fe -d" into a separate functionJonathan Nieder, May 27, 2011
  3. Drew NorthupMay 31, 2011
  4. Jonathan NiederMay 31, 2011
  5. 2/4 vcs-svn: cap number of bytes read from sliding viewJonathan Nieder, May 27, 2011
  6. 3/4 vcs-svn: guard against overflow when computing preimage lengthJonathan Nieder, May 27, 2011
  7. 4/4 vcs-svn: avoid hangs from corrupt deltasJonathan Nieder, May 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.