git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 01/02] git-instaweb: Simplify build dependency on gitweb

From
Jakub Narebski <jnareb@gmail.com>
Date
May 7, 2011, 12:45 UTC
Message-ID
<1304772321-22687-2-git-send-email-jnareb@gmail.com>
In-Reply-To
<1304772321-22687-1-git-send-email-jnareb@gmail.com>

Since c0cb4ed (git-instaweb: Configure it to work with new gitweb structure, 2010-05-28) git-instaweb does not re-create gitweb.cgi etc., but makes use of installed gitweb. Therefore simplify git-instaweb dependency on gitweb subsystem in main Makefile from 'gitweb/gitweb.cgi gitweb/static/gitweb.css gitweb/static/gitweb.js' to simply 'gitweb'.

This is preparation for splitting gitweb.perl script, and for splitting gitweb.js (to be reassembled / combined on build). This way we don't have to duplicate parts of gitweb/Makefile in main Makefile... it is also more correct description of git-instaweb dependency.

Reported-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch is part of 'jn/gitweb-js' (a76424e) in 'pu', and was sent
to git mailing list as part of the following series:
  [PATCHv3 00/13] gitweb: Change timezone in dates using JavaScript
  http://thread.gmane.org/gmane.comp.version-control.git/172384

I think this simplification of git-instaweb dependencies is worth on its own, even if gitweb.js won't be generated file.

P.S. Now that it is standalone, Reported-by makes little sense, though...
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index cbc3fce..8960cee 100644
--- a/Makefile
+++ b/Makefile
@@ -1773,7 +1773,7 @@ gitweb/static/gitweb.min.css: gitweb/static/gitweb.css
 endif # CSSMIN
 
 
-git-instaweb: git-instaweb.sh gitweb/gitweb.cgi gitweb/static/gitweb.css gitweb/static/gitweb.js
+git-instaweb: git-instaweb.sh gitweb
 	$(QUIET_GEN)$(RM) $@ $@+ && \
 	sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
 	    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
-- 
1.7.3
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 4 in “[PATCHv4 00/02] Simplify handling of gitweb dependencies and targets in main Makefile”
  1. Jakub NarebskiMay 7, 2011
  2. 01/02 git-instaweb: Simplify build dependency on gitwebJakub Narebski, May 7, 2011
  3. 02/02 Remove gitweb/gitweb.cgi and other legacy targets from main MakefileJakub Narebski, May 7, 2011
  4. Junio C HamanoMay 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.