git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t3701: Editing a split hunk in an "add -p" session

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 29, 2011, 22:49 UTC
Message-ID
<1304117373-592-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1304117373-592-1-git-send-email-gitster@pobox.com>

Arnaud Lacombe reported that with the recent change to reject overlapping hunks fed to "git apply", the edit mode of an "add -p" session that lazily feeds overlapping hunks without coalescing adjacent ones claim that the patch does not apply. Expose the problem to be fixed.

Cf. http://thread.gmane.org/gmane.comp.version-control.git/170685/focus=171000
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t3701-add-interactive.sh |   36 ++++++++++++++++++++++++++++++++++++
 1 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
index d6327e7..72559e1 100755
--- a/t/t3701-add-interactive.sh
+++ b/t/t3701-add-interactive.sh
@@ -295,4 +295,40 @@ test_expect_success PERL 'deleting an empty file' '
 	test_cmp expected diff
 '
 
+test_expect_success PERL 'split hunk setup' '
+	git reset --hard &&
+	for i in 10 20 30 40 50 60
+	do
+		echo $i
+	done >test &&
+	git add test &&
+	test_tick &&
+	git commit -m test &&
+
+	for i in 10 15 20 21 22 23 24 30 40 50 60
+	do
+		echo $i
+	done >test
+'
+
+test_expect_failure PERL 'split hunk "add -p (edit)"' '
+	# Split, say Edit and do nothing.  Then:
+	#
+	# 1. Broken version results in a patch that does not apply and
+	# only takes [y/n] (edit again) so the first q is discarded
+	# and then n attempts to discard the edit. Repeat q enough
+	# times to get out.
+	#
+	# 2. Correct version applies the (not)edited version, and asks
+	#    about the next hunk, against wich we say q and program
+	#    exits.
+	for a in s e     q n q q
+	do
+		echo $a
+	done |
+	EDITOR=: git add -p &&
+	git diff >actual &&
+	! grep "^+15" actual
+'
+
 test_done
-- 
1.7.5.252.g565191
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 4 in “Return of "add -p [E]dit" fix”
  1. 0/3 Return of "add -p [E]dit" fixJunio C Hamano, Apr 29, 2011
  2. 1/3 t3701: Editing a split hunk in an "add -p" sessionJunio C Hamano, Apr 29, 2011
  3. 2/3 add--interactive.perl: factor out repeated --recount optionJunio C Hamano, Apr 29, 2011
  4. 3/3 "add -p": work-around an old laziness that does not coalesce hunksJunio C Hamano, Apr 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.