git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] strbuf: allocate enough space when strbuf_setlen() is called first time

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Apr 26, 2011, 12:24 UTC
Message-ID
<1303820660-744-1-git-send-email-pclouds@gmail.com>

strbuf_grow(sb, 0) may allocate less than requested len and violate the next assertion.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 strbuf.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/strbuf.h b/strbuf.h
index 07060ce..ab213da 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -34,7 +34,7 @@ extern void strbuf_grow(struct strbuf *, size_t);
 
 static inline void strbuf_setlen(struct strbuf *sb, size_t len) {
 	if (!sb->alloc)
-		strbuf_grow(sb, 0);
+		strbuf_grow(sb, len);
 	assert(len < sb->alloc);
 	sb->len = len;
 	sb->buf[len] = '\0';
-- 
1.7.4.74.g639db
Next: Nguyen Thai Ngoc Duy
Message 1 of 11 in “strbuf: allocate enough space when strbuf_setlen() is called first time”
  1. strbuf: allocate enough space when strbuf_setlen() is called first timeNguyễn Thái Ngọc Duy, Apr 26, 2011
  2. Nguyen Thai Ngoc DuyApr 26, 2011
  3. Junio C HamanoApr 26, 2011
  4. Nguyen Thai Ngoc DuyApr 26, 2011
  5. René ScharfeApr 26, 2011
  6. Junio C HamanoApr 26, 2011
  7. René ScharfeApr 26, 2011
  8. Junio C HamanoApr 26, 2011
  9. René ScharfeApr 27, 2011
  10. Junio C HamanoApr 28, 2011
  11. Nguyen Thai Ngoc DuyApr 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.