git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] stash: add two more tests for --no-keep-index

From
Dan McGee <dpmcgee@gmail.com>
Date
Apr 7, 2011, 17:04 UTC
Message-ID
<1302195860-31053-1-git-send-email-dpmcgee@gmail.com>

One of these passes just fine; the other one exposes a problem where command line flag order matters for --no-keep-index and --patch interaction.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
---
 t/t3903-stash.sh       |    8 ++++++++
 t/t3904-stash-patch.sh |   12 ++++++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index f62aaf5..bca2df1 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -218,6 +218,14 @@ test_expect_success 'stash -k' '
 	test bar,bar4 = $(cat file),$(cat file2)
 '
 
+test_expect_success 'stash --no-keep-index' '
+	echo bar33 > file &&
+	echo bar44 > file2 &&
+	git add file2 &&
+	git stash --no-keep-index &&
+	test bar,bar2 = $(cat file),$(cat file2)
+'
+
 test_expect_success 'stash --invalid-option' '
 	echo bar5 > file &&
 	echo bar6 > file2 &&
diff --git a/t/t3904-stash-patch.sh b/t/t3904-stash-patch.sh
index 1e7193a..4d58789 100755
--- a/t/t3904-stash-patch.sh
+++ b/t/t3904-stash-patch.sh
@@ -48,6 +48,18 @@ test_expect_success PERL 'git stash -p --no-keep-index' '
 	verify_state bar dummy bar_index
 '
 
+test_expect_failure PERL 'git stash --no-keep-index -p' '
+	set_state dir/foo work index &&
+	set_state bar bar_work bar_index &&
+	(echo n; echo y) | git stash save --no-keep-index -p &&
+	verify_state dir/foo head head &&
+	verify_state bar bar_work dummy &&
+	git reset --hard &&
+	git stash apply --index &&
+	verify_state dir/foo work index &&
+	verify_state bar dummy bar_index
+'
+
 test_expect_success PERL 'none of this moved HEAD' '
 	verify_saved_head
 '
-- 
1.7.4.4
Next: Dan McGee
Message 1 of 2 in “stash: add two more tests for --no-keep-index”
  1. 1/2 stash: add two more tests for --no-keep-indexDan McGee, Apr 7, 2011
  2. 2/2 stash: ensure --no-keep-index and --patch can be used in any orderDan McGee, Apr 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.