git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] cmd_clone: free dir and path buffers

From
Carlos Martín Nieto <cmn@elego.de>
Date
Mar 31, 2011, 14:18 UTC
Message-ID
<1301581122-19947-1-git-send-email-cmn@elego.de>

The variables dir and path are always allocated on the stack so it's always safe to free them.

This memory would be freed by _exit, but it's good form to free memory you've allocated.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---
 This is a split-up version of an earlier patch. It's not a big deal,
but I had it in a local branch and I though I'd try to have it merged upstream.
 builtin/clone.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 2ee1fa9..fe0408c 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -665,6 +665,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 			err = run_command_v_opt(argv_submodule, RUN_GIT_CMD);
 	}
 
+	free(dir);
+	free(path);
 	strbuf_release(&reflog_msg);
 	strbuf_release(&branch_top);
 	strbuf_release(&key);
-- 
1.7.4.1
Next: Carlos Martín Nieto
Message 1 of 6 in “cmd_clone: free dir and path buffers”
  1. 1/2 cmd_clone: free dir and path buffersCarlos Martín Nieto, Mar 31, 2011
  2. 2/2 cmd_clone: make sure repo is allocated on the stack and free itCarlos Martín Nieto, Mar 31, 2011
  3. John SzakmeisterMar 31, 2011
  4. Carlos Martín NietoMar 31, 2011
  5. 1/2 cmd_clone: free dir and path buffersCarlos Martín Nieto, Mar 31, 2011
  6. 2/2 cmd_clone: make sure repo is allocated on the heap and free itCarlos Martín Nieto, Mar 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.