git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Test failure when spaces in git root

From
CSCarl Michael Skog <cmskog@gmail.com>
Date
Mar 24, 2011, 00:11 UTC
Message-ID
<1300925506-20378-1-git-send-email-cmskog@gmail.com>

Some of the svn related tests would break when the git root path had spaces in it.

The test checks in t/t9119-git-svn-info.sh where falsely assuming that the only space where in the path of the generated subversion repository. This will break when the actual git build repository has spaces in it. Add a global modifier to the sed command that generates the expected value for the tests.

Signed-off-by: Carl Michael Skog <cmskog@gmail.com>
---
 t/t9119-git-svn-info.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh
index ff19695..752bf26 100755
--- a/t/t9119-git-svn-info.sh
+++ b/t/t9119-git-svn-info.sh
@@ -28,7 +28,7 @@ test_cmp_info () {
 	rm -f tmp.expect tmp.actual
 }
 
-quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
+quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"
 
 test_expect_success 'setup repository and import' '
 	mkdir info &&
-- 
1.7.4.1.99.g3d9132
Next: Thomas Rast
Message 1 of 2 in “Test failure when spaces in git root”
  1. Test failure when spaces in git rootCarl Michael Skog, Mar 24, 2011
  2. Thomas RastMar 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.