git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Work around broken ln on solaris as used in t8006

From
Ben Walton <bwalton@artsci.utoronto.ca>
Date
Mar 21, 2011, 01:10 UTC
Message-ID
<1300669724-sup-450@pinkfloyd.chass.utoronto.ca>
In-Reply-To
<7vd3lluvze.fsf@alter.siamese.dyndns.org>
Excerpts from Junio C Hamano's message of Sun Mar 20 21:02:13 -0400 2011:
Hi Junio,
> > This patch uses changes the first check in the test to rm the symlink
> > and then create the new symlink using only -s.
> 
> s/uses //; I think.

Yes, I caught that right after send. A follow up corrected it, but I'll resubmit taking your feedback below into account.

> It is curious why "rm symlink.bin" is not inside the
> test-have-prereq part, iow, immediately before the problematic "ln
> -s", where it logically belongs to, though.  What does the updated
> code do on systems without symbolic link support?

I think you're right about this. They should be logically grouped. I'll send an update shortly.

Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302

Previous: Junio C HamanoNext: Ben Walton
Message 4 of 6 in “Work around broken ln on solaris as used in t8006”
  1. Work around broken ln on solaris as used in t8006Ben Walton, Mar 20, 2011
  2. Work around broken ln on solaris as used in t8006Ben Walton, Mar 21, 2011
  3. Junio C HamanoMar 21, 2011
  4. Ben WaltonMar 21, 2011
  5. Work around broken ln on solaris as used in t8006Ben Walton, Mar 21, 2011
  6. Junio C HamanoMar 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.