Re: [PATCH] find_unique_abbrev(): honor caller-supplied "len" better

From: Namhyung Kim <namhyung@gmail.com>
Date: Mar 19, 2011, 16:24 UTC
Message-ID: <1300551873.1462.8.camel@leonhard>
In-Reply-To: <AANLkTimH6ZKkTZ0MiJWzHpZywSy6Hk3caLQ5S+rE0uqg@mail.gmail.com>

2011-03-18 (금), 21:22 -0400, Jay Soffian:

Show 13 quoted lines

> On Fri, Mar 11, 2011 at 5:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > +core.abbrevLength::
> > +       Set the length object names are abbreviated to.  If unspecified,
> > +       many commands abbreviate to 7 hexdigits, which may not be enough
> > +       for abbreviated object names to stay unique for sufficiently long
> > +       time.
> > +
> 
> Isn't this the minimum length though? i.e. a longer length is used as
> needed for uniqueness. If so, at least the description is misleading,
> and I'd argue the option name too. Perhaps core.abbrevMinLength?
> 
> j.

It could confuse what it points is the default length or the minimum. I'd like to suggest core.defaultAbbrev or core.abbrevDefault.

-- 
Regards,
Namhyung Kim