Re: [PATCH] pretty.c: Make user defined format honor color option
- From
Will Palmer <wmpalmer@gmail.com>
- Date
- Mar 17, 2011, 12:59 UTC
- Message-ID
- <1300366792.3269.24.camel@wpalmer.simply-domain>
- In-Reply-To
- <4D81F860.2070703@secunet.com>
On Thu, 2011-03-17 at 13:02 +0100, Thomas Egerer wrote:
Show 16 quoted lines
> On 03/17/2011 10:39 AM, Will Palmer schrobtete: > > On Thu, 2011-03-17 at 09:33 +0100, Thomas Egerer wrote: > >> This patch fixes that the pretty-formats tformat and format ignore > >> git's color option. > > > > It is my understanding that this is intentional, the logic being: If you > > normally don't want color, but have specified it directly on the > > command-line, you probably want color. > I'm using the pretty format in the context of an alias. My global setting > for colors is auto. I would expect git to not disregard this options. I > usually use the alias to display a git log in a modified way, but I also > do sometimes pipe it to grep. If there was a way to suppress output > colorization (let's say by not using global options but the command line > switch --color=never) that would work for me. But there is no wa and I > find it inconvinient to have two different aliases doing the same thing > one with color and one without while there would be a much simpler way.
...snip
> Thomas
Perhaps --color=auto, specified on the command-line, should behave differently to the various color options specified via config. That might make both sides happy, as one could always specify --color=auto to explicitly tell git to only color if it thinks it should.
Can anyone else refresh my memory regarding the use-case where hand-specified colors really should have an effect even with --color=never?