Re: [PATCH] upload-pack: add a trigger for post-upload-pack hook
- From
- Tom Werner <mojombo@gmail.com>
- Date
- Aug 31, 2009, 18:50 UTC
- Message-ID
- <12c267e40908311150n2aad598aw978c4691c27ac0fa@mail.gmail.com>
- In-Reply-To
- <7vljl3p2iw.fsf@alter.siamese.dyndns.org>
On Fri, Aug 28, 2009 at 11:17 PM, Junio C Hamano<gitster@pobox.com> wrote:
Show 22 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > >>> I'd like to suggest the following line from the original patch: >>> >>> full-pack integer:: >>> 1 if the request was considered a full clone, 0 if it was a >>> partial update (fetch) >> >> If it is all "want" and no "have", it is clone or fetch into empty >> repository. If additionaly "want"s cover all refs, it is a clone. >> No need to pass this information: it can be derived. > > Well, not exactly. > > Here is an iffy RFC patch. Iffy not in the sense that its implementation > is questionable, but in the sense that I am not really convinced if the > distinction between fetching some (or in the worst case, most) but not all > refs, and fetching full set of refs, into an empty repository is something > worth making. > > Does anybody from GitHub have any input? Is there something that can > still improved to suit GitHub's needs?
From GitHub's perspective, we'd treat any clone or fetch into an empty repo as a clone operation, whether or not that included all of the refs that were available. For us, the distinction between full and partial clones is too nuanced to warrant additional code. I'd be happy with the previous incarnation of the post-upload-pack that simply sends the HAVEs and WANTs.
Tom