git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* [PATCH 1/2] sha1_name: try to use same abbrev length when core.abbrevguard is specified

From
Namhyung Kim <namhyung@gmail.com>
Date
Mar 10, 2011, 11:54 UTC
Message-ID
<1299758084.1499.36.camel@leonhard>
In-Reply-To
<1299757966.1499.34.camel@leonhard>
2011-03-10 (목), 20:52 +0900, Namhyung Kim:
Show 16 quoted lines
> 2011-03-10 (목), 01:19 -0800, Junio C Hamano:
> > And here is an attempt to do so.  I have to admit that I didn't give it
> > too much thought, though, so please be careful when reviewing the logic.
> > 
> 
> What if the unique length is greater than or equal to the given length?
> For instance the unique length is 7 and the caller gives 7 and the guard
> is 3. What do you want to return, 7 or 10? How about the unique length
> of 8?
> 
> I think the meaning of the guard is somewhat vague. When this feature
> was considered in LKML at first, Linus just wanted to change the default
> length of commit abbreviation to 12 by making it user-configurable. [1]
> And this is the same situation what I tried to tell you in the previous
> email.
> 
Oh, I missed the link. :)
[1] https://lkml.org/lkml/2010/10/28/264
-- 
Regards,
Namhyung Kim
Previous: Namhyung KimNext: Junio C Hamano
Message 11 of 13 in “sha1_name: try to use same abbrev length when core.abbrevguard is specified”
  1. 1/2 sha1_name: try to use same abbrev length when core.abbrevguard is specifiedNamhyung Kim, Mar 8, 2011
  2. 2/2 blame: introduce -u/--unique optionNamhyung Kim, Mar 8, 2011
  3. Junio C HamanoMar 9, 2011
  4. Namhyung KimMar 10, 2011
  5. Junio C HamanoMar 10, 2011
  6. Namhyung KimMar 10, 2011
  7. Junio C HamanoMar 9, 2011
  8. Junio C HamanoMar 9, 2011
  9. Re* [PATCH 1/2] sha1_name: try to use same abbrev length when core.abbrevguard is specifiedJunio C Hamano, Mar 10, 2011
  10. Namhyung KimMar 10, 2011
  11. Namhyung KimMar 10, 2011
  12. Junio C HamanoMar 10, 2011
  13. Namhyung KimMar 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.