Re: Re* [PATCH 1/2] sha1_name: try to use same abbrev length when core.abbrevguard is specified
2011-03-10 (목), 20:52 +0900, Namhyung Kim:
Show 16 quoted lines
> 2011-03-10 (목), 01:19 -0800, Junio C Hamano:
> > And here is an attempt to do so. I have to admit that I didn't give it
> > too much thought, though, so please be careful when reviewing the logic.
> >
>
> What if the unique length is greater than or equal to the given length?
> For instance the unique length is 7 and the caller gives 7 and the guard
> is 3. What do you want to return, 7 or 10? How about the unique length
> of 8?
>
> I think the meaning of the guard is somewhat vague. When this feature
> was considered in LKML at first, Linus just wanted to change the default
> length of commit abbreviation to 12 by making it user-configurable. [1]
> And this is the same situation what I tried to tell you in the previous
> email.
>
Oh, I missed the link. :)
[1] https://lkml.org/lkml/2010/10/28/264
--
Regards,
Namhyung Kim