git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/3] t/gitweb-lib.sh: print to stderr when gitweb_run has errors

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 19, 2011, 15:27 UTC
Message-ID
<1298129262-10468-2-git-send-email-avarab@gmail.com>
In-Reply-To
<1298124654-12051-1-git-send-email-avarab@gmail.com>

Change the gitweb_run test subroutine to spew errors to stderr if there are any, previously it would just silently fail, which made tests very hard to debug.

Before you'd get this output, when running tests under `--verbose --immediate --debug`:

    expecting success: git rm renamed_file &&
             rm -f renamed_file &&
             git commit -a -m "File removed." &&
             gitweb_run "p=.git;a=commitdiff"
    rm 'renamed_file'
    [master 8d80741] File removed.
     Author: A U Thor <author@example.com>
     1 files changed, 0 insertions(+), 1 deletions(-)
     delete mode 120000 renamed_file
    not ok - 32 commitdiff(0): file deleted
    #       git rm renamed_file &&
    #                rm -f renamed_file &&
    #                git commit -a -m "File removed." &&
    #                gitweb_run "p=.git;a=commitdiff"
Now you'll get the much more useful:
    expecting success: git rm renamed_file &&
             rm -f renamed_file &&
             git commit -a -m "File removed." &&
             gitweb_run "p=.git;a=commitdiff"
    rm 'renamed_file'
    [master 2a4214e] File removed.
     Author: A U Thor <author@example.com>
     1 files changed, 0 insertions(+), 1 deletions(-)
     delete mode 120000 renamed_file
    [Sat Feb 19 14:32:54 2011] gitweb.perl: Use of uninitialized value in subroutine entry at /home/avar/g/git/t/../gitweb/gitweb.perl line 4415.
    not ok - 32 commitdiff(0): file deleted
    #       git rm renamed_file &&
    #                rm -f renamed_file &&
    #                git commit -a -m "File removed." &&
    #                gitweb_run "p=.git;a=commitdiff"
---
 t/gitweb-lib.sh |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index b9bb95f..2388b0f 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -82,7 +82,12 @@ gitweb_run () {
 		}
 		close O;
 	' gitweb.output &&
-	if grep '^[[]' gitweb.log >/dev/null 2>&1; then false; else true; fi
+	if grep '^[[]' gitweb.log >/dev/null 2>&1; then
+		cat gitweb.log >&2
+		false
+	else
+		true
+	fi
 
 	# gitweb.log is left for debugging
 	# gitweb.output is used to parse HTTP output
-- 
1.7.2.3
Previous: Ævar Arnfjörð BjarmasonNext: Jakub Narebski
Message 3 of 15 in “gitweb/gitweb.perl: remove use of qw(...) as parentheses”
  1. gitweb/gitweb.perl: remove use of qw(...) as parenthesesÆvar Arnfjörð Bjarmason, Feb 19, 2011
  2. 0/3 Fix failure-causing warnings in Gitweb + improve gitweb-lib.shÆvar Arnfjörð Bjarmason, Feb 19, 2011
  3. 1/3 t/gitweb-lib.sh: print to stderr when gitweb_run has errorsÆvar Arnfjörð Bjarmason, Feb 19, 2011
  4. Jakub NarebskiFeb 19, 2011
  5. Ævar Arnfjörð BjarmasonFeb 19, 2011
  6. Jakub NarebskiFeb 19, 2011
  7. Ævar Arnfjörð BjarmasonFeb 19, 2011
  8. Junio C HamanoFeb 21, 2011
  9. 2/3 gitweb/gitweb.perl: remove use of qw(...) as parenthesesÆvar Arnfjörð Bjarmason, Feb 19, 2011
  10. Jakub NarebskiFeb 19, 2011
  11. Jakub NarebskiFeb 19, 2011
  12. Ævar Arnfjörð BjarmasonFeb 19, 2011
  13. Jakub NarebskiFeb 20, 2011
  14. 3/3 gitweb/gitweb.perl: don't call S_ISREG() with undefÆvar Arnfjörð Bjarmason, Feb 19, 2011
  15. Jakub NarebskiFeb 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.