[PATCH v2 2/8] git-p4: fix key error for p4 problem
- From
- Pete Wyckoff <pw@padd.com>
- Date
- Feb 19, 2011, 13:17 UTC
- Message-ID
- <1298121481-7005-3-git-send-email-pw@padd.com>
- In-Reply-To
- <1298121481-7005-1-git-send-email-pw@padd.com>
Some p4 failures result in an error, but the info['code'] is not set. These include a bad p4 executable, or a core dump from p4, and other odd internal errors where p4 fails to generate proper marshaled output.
Make sure the info key exists before using it to avoid a python traceback.
Signed-off-by: Pete Wyckoff <pw@padd.com> --- contrib/fast-import/git-p4 | 5 ++++- t/t9800-git-p4.sh | 13 +++++++++++++ 2 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index 04ce7e3..2fefea4 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -1440,10 +1440,13 @@ class P4Sync(Command): % (p, revision) for p in self.depotPaths])): - if info['code'] == 'error': + if 'code' in info and info['code'] == 'error': sys.stderr.write("p4 returned an error: %s\n" % info['data']) sys.exit(1) + if 'p4ExitCode' in info: + sys.stderr.write("p4 exitcode: %s\n" % info['p4ExitCode']) + sys.exit(1) change = int(info["change"]) diff --git a/t/t9800-git-p4.sh b/t/t9800-git-p4.sh index 2d354f8..c1ea4d4 100755 --- a/t/t9800-git-p4.sh +++ b/t/t9800-git-p4.sh @@ -45,6 +45,19 @@ test_expect_success 'basic git-p4 clone' ' rm -rf "$git" && mkdir "$git" ' +test_expect_success 'exit when p4 fails to produce marshaled output' ' + badp4dir="$TRASH_DIRECTORY/badp4dir" && + mkdir -p "$badp4dir" && + cat >"$badp4dir"/p4 <<-EOF && + #!$SHELL_PATH + exit 1 + EOF + chmod 755 "$badp4dir"/p4 && + PATH="$badp4dir:$PATH" "$GITP4" clone --dest="$git" //depot >errs 2>&1 ; retval=$? && + test $retval -eq 1 && + test_must_fail grep -q Traceback errs +' + test_expect_success 'shutdown' ' pid=`pgrep -f p4d` && test -n "$pid" &&
-- 1.7.4.1