Re: [PATCH] Handle rename of case only, for Windows

Shouldn't you check the return value of this call? OK, the source probably always exists, but still. Oh, we actually know that because that's the first lstat() call in this for loop. You can reuse its result instead of calling the function again.

Thanks for your feedback, you are undoubtedly right about checking the return value, I hadn't though of that. Just out of interest I tried moving a file with git mv that i'd removed from the filesystem. Here's the result, so at least it's not dying horribly:

  $ rm foo.txt

  $ git status
  # On branch master
  # Changed but not updated:
  #   (use "git add/rm <file>..." to update what will be committed)
  #   (use "git checkout -- <file>..." to discard changes in working directory)
  #
  #       deleted:    foo.txt
  #
  no changes added to commit (use "git add" and/or "git commit -a")

  $ git mv foo.txt bar.txt
  fatal: bad source, source=foo.txt, destination=bar.txt

--

What do I need to do from here to make my patch acceptable/useful to git's maintainers?

Thanks

Tim Abell