Re: [PATCH 0/1] grep: align default colors with GNU grep ones

From: Lénaïc Huard <lenaic@lhuard.fr>
Date: Jan 5, 2022, 08:21 UTC
Message-ID: <12926486.uLZWGnKmhe@coruscant.lhuard.fr>
In-Reply-To: <xmqq4k6kjvdd.fsf@gitster.g>

Le lundi 3 janvier 2022, 23:40:46 CET Junio C Hamano a écrit :

Show 18 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> > […]
> > 
> > The UI color choice is so personal, which does not help us either.
> > 
> > Having said that, I'll keep an eye on what others say on this
> > thread.
> 
> It's been a bit more than a week and it seems nobody else is
> interested in supporting this change [*1*].
> 
> Whether we want this change or not, I just noticed that the real
> patch [1/1] has no commit log message, and most of what is in the
> above "cover letter" would would make a good material for the log
> message.  Perhaps we'd want to redo the log message if it turns out
> that we want to take this change.
> 
> […]

Thank you very much for your feedback.

I’ve just re-rolled the patch to only move the cover letter to the commit message in case the patch is eventually accepted.

I proposed this patch because I thought that people picky about colors would have customized them anyway and people less picky about colors would leave the default and would find smarter to have the same color scheme for different tools doing the same thing (`git grep` and `GNU grep`). I choose to align `git grep` on `GNU grep` because the latter has a more colorful scheme and elements already colored in both schemes are already sharing the same color.

I however understand your points and I would understand if the patch is dropped if it isn’t worth having to justify a change of default values.