git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] gitweb: remove test when closing file descriptor

From
Sylvain Rabot <sylvain@abstraction.fr>
Date
Dec 16, 2010, 21:43 UTC
Message-ID
<1292535801-7421-4-git-send-email-sylvain@abstraction.fr>
In-Reply-To
<1292535801-7421-1-git-send-email-sylvain@abstraction.fr>

it happens that closing file descriptor fails whereas the blob is perfectly readable.

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
---
 gitweb/gitweb.perl |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9398475..9a885b1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3450,8 +3450,7 @@ sub run_highlighter {
 	my ($fd, $highlight, $syntax) = @_;
 	return $fd unless ($highlight && defined $syntax);
 
-	close $fd
-		or die_error(404, "Reading blob failed");
+	close $fd;
 	open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
 	          quote_command($highlight_bin).
 	          " --xhtml --fragment --syntax $syntax |"
-- 
1.7.3.2
Previous: Drew NorthupNext: Jakub Narebski
Message 9 of 12 in “minor gitweb modifications”
  1. 0/3 minor gitweb modificationsSylvain Rabot, Dec 16, 2010
  2. 1/3 gitweb: add extensions to highlight featureSylvain Rabot, Dec 16, 2010
  3. Jakub NarebskiDec 16, 2010
  4. Sylvain RabotDec 16, 2010
  5. Jakub NarebskiDec 17, 2010
  6. 2/3 gitweb: decorate a bit more remotesSylvain Rabot, Dec 16, 2010
  7. Jakub NarebskiDec 16, 2010
  8. Drew NorthupDec 20, 2010
  9. 3/3 gitweb: remove test when closing file descriptorSylvain Rabot, Dec 16, 2010
  10. Jakub NarebskiDec 16, 2010
  11. Sylvain RabotDec 16, 2010
  12. Jakub NarebskiNov 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.