Re: [PATCH] git-add.txt: Order options alphabetically

From: Drew Northup <drew.northup@maine.edu>
Date: Dec 1, 2010, 19:49 UTC
Message-ID: <1291232990.11917.40.camel@drew-northup.unet.maine.edu>
In-Reply-To: <87fwuhuwdu.fsf@picasso.cante.net>

On Wed, 2010-12-01 at 21:27 +0200, Jari Aalto wrote:

Show 16 quoted lines

> 2010-12-01 20:53 Drew Northup <drew.northup@maine.edu>:
> > On Wed, 2010-12-01 at 17:42 +0200, jari.aalto@cante.net wrote:
> > First off, this patch (and set I've seen thus far) has little no commit
> > message.
> 
> There is no point of making it any longer as it is basically the same
> for everything. I don't think we want to see long identical copies of
> explanations over and over in "git log".
> 
> > Did you plan on changing the the short help displayed by git add -h as
> > well?
> 
> Don't know. At this time, I happen to have some free time. But that's a
> good candidate for followup work.
> 
> Jari

First, before I reply to your post proper, I am going to echo others on this list--unless you see a good specific reason to prune the CC/reply list please leave it intact and use "reply all" and not "reply to list" here once a conversation has been started. (Other lists may have different conventions, and I am still absorbing some of the ones used here myself...)

That said, like changes should be grouped together in closely related patchsets. It makes life easier for everybody. Don't worry about using virtually the same commit message over and over again if that's what is actually appropriate. Junio may very well rebase/restructure patches that need it (I haven't checked to see how often he bothers) and will tell you if patch structure is completely out of line or unusable--but that's not the same as others actually reviewing the changes themselves.

See

Message-ID: <20101201165043.GF26120@burratino>

These changes should be a bundle, this bundle should have a "meta message", and each element should have a commit message.

-- 
-Drew Northup N1XIM
   AKA RvnPhnx on OPN
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59