git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] gitk: Update cherry-pick error message parsing

From
Anders Kaseorg <andersk@mit.edu>
Date
Nov 19, 2010, 07:38 UTC
Message-ID
<1290152300-21393-1-git-send-email-andersk@mit.edu>
Commit 981ff5c37ae20687c98d98c8689d5e89016026d2 changed the error
message from git cherry-pick from
    Automatic cherry-pick failed.  [...advice...]
to
    error: could not apply 7ab78c9... Do something neat.
    [...advice...]

Update gitk’s regex to match this, restoring the ability to launch git citool to resolve conflicted cherry-picks.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
---
 gitk-git/gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 1b0e09a..dbc8f86 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -9002,7 +9002,7 @@ proc cherrypick {} {
 			to file '%s'.\nPlease commit, reset or stash\
 			your changes and try again." $fname]
 	} elseif {[regexp -line \
-		       {^(CONFLICT \(.*\):|Automatic cherry-pick failed)} \
+		       {^(CONFLICT \(.*\):|Automatic cherry-pick failed|error: could not apply)} \
 		       $err]} {
 	    if {[confirm_popup [mc "Cherry-pick failed because of merge\
 			conflict.\nDo you wish to run git citool to\
-- 
1.7.3.2
Next: Anders Kaseorg
Message 1 of 4 in “gitk: Update cherry-pick error message parsing”
  1. 1/4 gitk: Update cherry-pick error message parsingAnders Kaseorg, Nov 19, 2010
  2. 2/4 gitk: Remove unused $cdate arrayAnders Kaseorg, Nov 19, 2010
  3. 3/4 gitk: Remember time zones from author and commit timestampsAnders Kaseorg, Nov 19, 2010
  4. 4/4 gitk: Allow displaying time zones from author and commit timestampsAnders Kaseorg, Nov 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.