git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] rebase -X: do not clobber strategy

From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date
Nov 10, 2010, 07:14 UTC
Message-ID
<1289373266-32593-1-git-send-email-martin.von.zweigbergk@gmail.com>

If any strategy options are passed to -X, the strategy will always be set to 'recursive'. According to the documentation, it should default to 'recursive' if it is not set, but it should be possible to set it to other values.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
---
 git-rebase.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index 42c0628..ec08f9c 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -312,10 +312,6 @@ do
 		esac
 		strategy_opts="$strategy_opts $(git rev-parse --sq-quote "--$newopt")"
 		do_merge=t
-		if test -n "$strategy"
-		then
-			strategy=recursive
-		fi
 		;;
 	-s=*|--s=*|--st=*|--str=*|--stra=*|--strat=*|--strate=*|\
 		--strateg=*|--strategy=*|\
-- 
1.7.3.2.167.ga361b
Next: Sverre Rabbelier
Message 1 of 8 in “rebase -X: do not clobber strategy”
  1. rebase -X: do not clobber strategyMartin von Zweigbergk, Nov 10, 2010
  2. Sverre RabbelierNov 10, 2010
  3. Martin von ZweigbergkNov 11, 2010
  4. Thomas RastNov 11, 2010
  5. Martin von ZweigbergkNov 11, 2010
  6. Junio C HamanoNov 11, 2010
  7. Martin von ZweigbergkNov 12, 2010
  8. Junio C HamanoNov 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.