Re: [RFC] Print diffs of UTF-16 to console / patches to email as UTF-8...?

From: Drew Northup <drew.northup@maine.edu>
Date: Oct 22, 2010, 17:01 UTC
Message-ID: <1287766916.31218.71.camel@drew-northup.unet.maine.edu>
In-Reply-To: <20101022161851.GH9224@burratino>

On Fri, 2010-10-22 at 11:18 -0500, Jonathan Nieder wrote:

Show 14 quoted lines

> Hi,
> 
> Drew Northup wrote:
> 
> >         This is part of my ongoing work to treat UTF-16 as text (in
> > other words, the crlf options will work and .gitattributes hacks won't
> > be required to display diffs, etc).
> 
> What's wrong with .gitattributes for this use case?  I would think a
> clean/smudge filter would produce very good behavior from most git
> commands.
> 
> If speed is the issue, maybe a built-in clean/smudge filter would
> address that?

That still doesn't fix the crlf issue, for starters. Also, I would like to be able to email patches for files that are in UTF-16 and properly re-import them. Unless I'm missing something really big there's not much that a display filter is going to do for me there. I want this to be two-way. To be honest, the not needing of a display filter goes along with treating UTF-16 patches as text. The same sort of code will be required for both, so why not get predictable behavior for another text encoding at the same time?

-- 
-Drew Northup N1XIM
   AKA RvnPhnx on OPN
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59