[PATCH v2] t/gitweb-lib: Don't pass constant to decode_utf8

From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Oct 20, 2010, 05:57 UTC
Message-ID: <1287554231-84196-1-git-send-email-brian@gernhardtsoftware.com>

Encode.pm started updating the string to decode in-place when a second argument is passed in version 2.40. This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message like:

Modification of a read-only value attempted at /Library/Perl/Updates/5.10.0/darwin-thread-multi-2level/Encode.pm line 216.

Work around this by passing an empty variable instead of a constant string.

Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---

 Changes since v1:
 - Use an explicitly empty variable instead of $_
 - Clearer commit message
 - CC people who worked on t/gitweb-lib.sh
 - based against maint

 t/gitweb-lib.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 81ef2a0..1b9523d 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
 	test_done
 fi
 
-perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
+perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
     skip_all='skipping gitweb tests, perl version is too old'
     test_done
 }

-- 
1.7.3.1.209.g52408