[PATCH] Make test script annotate-tests.sh handle missing authors
- From
Kevin Ballard <kevin@sb.org>
- Date
- Oct 16, 2010, 05:50 UTC
- Message-ID
- <1287208215-91901-1-git-send-email-kevin@sb.org>
Initialize the %count hash to contain all the expected authors already. This allows the script to print an error if an expected author was omitted entirely from the blame/annotate output.
Signed-off-by: Kevin Ballard <kevin@sb.org> --- I discovered this omission when trying to write a test for a change to git-blame that I will be submitting shortly. Without this change, if an author never showed up in the blame output, it would errneously consider that to be ok. It still ignores authors that were never specified as expected in the first place, but I wasn't so sure that was an error.
Also, I'm not a Perl programmer, so it's possible there's a better idiom for this sort of thing.
t/annotate-tests.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh index 396b965..4e37a66 100644 --- a/t/annotate-tests.sh +++ b/t/annotate-tests.sh @@ -9,6 +9,9 @@ check_count () { cat .result | perl -e ' my %expect = (@ARGV); my %count = (); + while (my ($author, $count) = each %expect) { + $count{$author} = 0; + } while (<STDIN>) { if (/^[0-9a-f]+\t\(([^\t]+)\t/) { my $author = $1;
-- 1.7.3.1.186.gc0af9.dirty