git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 01/21] notes.c: Hexify SHA1 in die() message from init_notes()

From
Johan Herland <johan@herland.net>
Date
Oct 9, 2010, 01:08 UTC
Message-ID
<1286586528-3473-2-git-send-email-johan@herland.net>
In-Reply-To
<1286586528-3473-1-git-send-email-johan@herland.net>
Signed-off-by: Johan Herland <johan@herland.net>
---
Found this while testing other aspects of this series.
...Johan
 notes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notes.c b/notes.c
index 1978244..bb03eb0 100644
--- a/notes.c
+++ b/notes.c
@@ -940,7 +940,7 @@ void init_notes(struct notes_tree *t, const char *notes_ref,
 		return;
 	if (get_tree_entry(object_sha1, "", sha1, &mode))
 		die("Failed to read notes tree referenced by %s (%s)",
-		    notes_ref, object_sha1);
+		    notes_ref, sha1_to_hex(object_sha1));
 
 	hashclr(root_tree.key_sha1);
 	hashcpy(root_tree.val_sha1, sha1);

-- 
1.7.3.1.104.g92b87a
Previous: Johan HerlandNext: Johan Herland
Message 2 of 25 in “[PATCHv3 00/21] git notes merge”
  1. Johan HerlandOct 9, 2010
  2. 01/21 notes.c: Hexify SHA1 in die() message from init_notes()Johan Herland, Oct 9, 2010
  3. 02/21 (trivial) notes.h: Minor documentation fixes to copy_notes()Johan Herland, Oct 9, 2010
  4. 03/21 notes.h: Make default_notes_ref() available in notes APIJohan Herland, Oct 9, 2010
  5. 04/21 notes.c: Reorder functions in preparation for next commitJohan Herland, Oct 9, 2010
  6. Junio C HamanoOct 13, 2010
  7. Jonathan NiederOct 13, 2010
  8. 05/21 notes.h/c: Clarify the handling of notes objects that are == null_sha1Johan Herland, Oct 9, 2010
  9. 06/21 notes.h/c: Propagate combine_notes_fn return value to add_note() and beyondJohan Herland, Oct 9, 2010
  10. 07/21 (trivial) t3303: Indent with tabs instead of spaces for consistencyJohan Herland, Oct 9, 2010
  11. 08/21 notes.c: Use two newlines (instead of one) when concatenating notesJohan Herland, Oct 9, 2010
  12. 09/21 builtin/notes.c: Split notes ref DWIMmery into a separate functionJohan Herland, Oct 9, 2010
  13. 10/21 git notes merge: Initial implementation handling trivial merges onlyJohan Herland, Oct 9, 2010
  14. 11/21 builtin/notes.c: Refactor creation of notes commits.Johan Herland, Oct 9, 2010
  15. 12/21 git notes merge: Handle real, non-conflicting notes mergesJohan Herland, Oct 9, 2010
  16. 13/21 git notes merge: Add automatic conflict resolvers (ours, theirs, union)Johan Herland, Oct 9, 2010
  17. 14/21 Documentation: Preliminary docs on 'git notes merge'Johan Herland, Oct 9, 2010
  18. 15/21 git notes merge: Manual conflict resolution, part 1/2Johan Herland, Oct 9, 2010
  19. 16/21 git notes merge: Manual conflict resolution, part 2/2Johan Herland, Oct 9, 2010
  20. 17/21 git notes merge: List conflicting notes in notes merge commit messageJohan Herland, Oct 9, 2010
  21. 18/21 git notes merge: --commit should fail if underlying notes ref has movedJohan Herland, Oct 9, 2010
  22. 19/21 git notes merge: Add another auto-resolving strategy: "cat_sort_uniq"Johan Herland, Oct 9, 2010
  23. 20/21 git notes merge: Add testcases for merging notes trees at different fanoutsJohan Herland, Oct 9, 2010
  24. 21/21 Provide 'git notes get-ref' to easily retrieve current notes refJohan Herland, Oct 9, 2010
  25. Sverre RabbelierOct 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.