git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/3] rev-parse: allow --flags to output rev-parse-like flags

From
Jon Seymour <jon.seymour@gmail.com>
Date
Sep 25, 2010, 11:22 UTC
Message-ID
<1285413763-25082-1-git-send-email-jon.seymour@gmail.com>

This series allows git rev-parse --flags to output remaining flag-like arguments even if such arguments are valid options to git rev-parse itself.

Previously:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -X
  $
Now:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -q -X --no-flags
  $
Note existing behaviour was:
  $ git rev-parse --flags HEAD
  HEAD
  $
This behaviour is unchanged by this series, but the documentation has
been updated to state that --flags:
  Do not output non-flag parameters which are not also revisions.

Reviewers are invited to comment on whether current behaviour is reasonable or whether the implementation should be changed to match the current documentation. That is, to make the behaviour:

  $ git rev-parse --flags HEAD
  $ 

This series differs from v2 in that 2/4 of the previous series was actually unnecesssary since --no-flags --flags -X already produced no output. The documentation has been reworded to relect current behaviour more accurately.

Aevar's feedback has been incorporated.
Jon Seymour (3):
  rev-parse: stop interpreting flags as options to rev-parse once
    --flags is specified
  rev-parse: add tests for git rev-parse --flags.
  rev-parse: update documentation of --flags and --no-flags options
 Documentation/git-rev-parse.txt |   14 ++++-
 builtin/rev-parse.c             |    8 +++
 t/t1510-rev-parse-flags.sh      |  109 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 129 insertions(+), 2 deletions(-)
 create mode 100755 t/t1510-rev-parse-flags.sh
-- 
1.7.3.3.g262a8
Next: Jon Seymour
Message 1 of 4 in “rev-parse: allow --flags to output rev-parse-like flags”
  1. 0/3 rev-parse: allow --flags to output rev-parse-like flagsJon Seymour, Sep 25, 2010
  2. 1/3 rev-parse: stop interpreting flags as options to rev-parse once --flags is specifiedJon Seymour, Sep 25, 2010
  3. 2/3 rev-parse: add tests for git rev-parse --flags.Jon Seymour, Sep 25, 2010
  4. 3/3 rev-parse: update documentation of --flags and --no-flags optionsJon Seymour, Sep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.