git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] mergetool-lib: combine vimdiff and gvimdiff run blocks

From
Dan McGee <dpmcgee@gmail.com>
Date
Sep 15, 2010, 02:21 UTC
Message-ID
<1284517303-17244-1-git-send-email-dpmcgee@gmail.com>

They are nearly identical outside of the foreground flag, which can safely be passed to both vim and gvim. The merge tool itself is named in $merge_tool_path.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
---
 git-mergetool--lib.sh |   17 +++--------------
 1 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index b5e1943..f9a51ba 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -169,25 +169,14 @@ run_merge_tool () {
 			"$merge_tool_path" "$LOCAL" "$REMOTE" | cat
 		fi
 		;;
-	vimdiff)
-		if merge_mode; then
-			touch "$BACKUP"
-			"$merge_tool_path" -d -c "wincmd l" \
-				"$LOCAL" "$MERGED" "$REMOTE"
-			check_unchanged
-		else
-			"$merge_tool_path" -d -c "wincmd l" \
-				"$LOCAL" "$REMOTE"
-		fi
-		;;
-	gvimdiff)
+	vimdiff|gvimdiff)
 		if merge_mode; then
 			touch "$BACKUP"
-			"$merge_tool_path" -d -c "wincmd l" -f \
+			"$merge_tool_path" -f -d -c "wincmd l" \
 				"$LOCAL" "$MERGED" "$REMOTE"
 			check_unchanged
 		else
-			"$merge_tool_path" -d -c "wincmd l" -f \
+			"$merge_tool_path" -f -d -c "wincmd l" \
 				"$LOCAL" "$REMOTE"
 		fi
 		;;
-- 
1.7.2.3
Next: Dan McGee
Message 1 of 10 in “mergetool-lib: combine vimdiff and gvimdiff run blocks”
  1. 1/2 mergetool-lib: combine vimdiff and gvimdiff run blocksDan McGee, Sep 15, 2010
  2. 2/2 mergetool-lib: add a three-way diff view for vim/gvimDan McGee, Sep 15, 2010
  3. David AguilarSep 18, 2010
  4. Felipe ContrerasSep 19, 2010
  5. Dan McGeeSep 24, 2010
  6. Jacob HelwigSep 24, 2010
  7. Jeff KingSep 24, 2010
  8. David AguilarSep 25, 2010
  9. 2/2 mergetool-lib: add a three-way diff view for vim/gvimDan McGee, Sep 27, 2010
  10. Jeff KingSep 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.