git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Mockup an svndiff version 0 parser

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Sep 4, 2010, 07:43 UTC
Message-ID
<1283586214-31204-1-git-send-email-artagnon@gmail.com>
Hi,
I finally rolled up my sleeves and wrote that svndiff0 parser
yesterday. I've tested it with a few source-target combinations, and
it seems to work fine. It's based on `master`, now that `jn/svn-fe`
has graduated. It's not intended for inclusion yet- it's more of a
"here's what I've been upto, and I'd like some feedback".
TODO:
1. malloc, realloc and free calls: I should factor these out to use
the obj_pool library in vcs-svn/
2. line_buffer. Only operations on stdin are currently
buffered. Should we extend the line_buffer library to be more generic?
3. Performance: The applier I've written is VERY naively. I can't help
but think that there must be a better way to do it. I still don't have
a solution though- the main problem is copyfrom_target.
4. Using the context dumpfilev3. The svndiff0 itself has no end
markers and it's difficult to say when it's going to end. Instead of
unconditionally waiting for more data (which is a problem when the
connection breaks), limit the number of bytes to parse using the
Content-Length header in the dumpfile v3.
Thanks.
p.s- I'll be MIA for a few weeks; exams are coming up in a week.
Ramkumar Ramachandra (1):
  vcs-svn: Add an svndiff0 parser
 vcs-svn/Makefile      |    2 +
 vcs-svn/line_buffer.c |    7 +-
 vcs-svn/line_buffer.h |    2 +-
 vcs-svn/svndiff.c     |  240 +++++++++++++++++++++++++++++++++++++++++++++++++
 vcs-svn/svndiff.h     |   41 +++++++++
 5 files changed, 288 insertions(+), 4 deletions(-)
 create mode 100644 vcs-svn/Makefile
 create mode 100644 vcs-svn/svndiff.c
 create mode 100644 vcs-svn/svndiff.h
-- 
1.7.2.2.409.gdbb11.dirty
Next: Ramkumar Ramachandra
Message 1 of 4 in “Mockup an svndiff version 0 parser”
  1. Mockup an svndiff version 0 parserRamkumar Ramachandra, Sep 4, 2010
  2. vcs-svn: Add an svndiff0 parserRamkumar Ramachandra, Sep 4, 2010
  3. vcs-svn: Avoid %z in format stringDavid Barr, Sep 4, 2010
  4. Ramkumar RamachandraSep 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.