git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] setup_unpack_trees_porcelain: take the whole options struct as parameter

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Sep 2, 2010, 11:57 UTC
Message-ID
<1283428655-12680-3-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<vpq39ttxumz.fsf@bauges.imag.fr>

This is a preparation patch to let setup_unpack_trees_porcelain set show_all_errors itself.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 builtin/checkout.c |    2 +-
 builtin/merge.c    |    2 +-
 merge-recursive.c  |    2 +-
 unpack-trees.c     |    4 +++-
 unpack-trees.h     |    3 ++-
 5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index e5c0ef0..b26dfd0 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -376,7 +376,7 @@ static int merge_working_tree(struct checkout_opts *opts,
 		topts.src_index = &the_index;
 		topts.dst_index = &the_index;
 
-		setup_unpack_trees_porcelain(topts.msgs, "checkout");
+		setup_unpack_trees_porcelain(&topts, "checkout");
 
 		refresh_cache(REFRESH_QUIET);
 
diff --git a/builtin/merge.c b/builtin/merge.c
index da52b10..389e79c 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -706,7 +706,7 @@ int checkout_fast_forward(const unsigned char *head, const unsigned char *remote
 	opts.merge = 1;
 	opts.fn = twoway_merge;
 	opts.show_all_errors = 1;
-	setup_unpack_trees_porcelain(opts.msgs, "merge");
+	setup_unpack_trees_porcelain(&opts, "merge");
 
 	trees[nr_trees] = parse_tree_indirect(head);
 	if (!trees[nr_trees++])
diff --git a/merge-recursive.c b/merge-recursive.c
index 61e237b..ebe6700 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -180,7 +180,7 @@ static int git_merge_trees(int index_only,
 	opts.fn = threeway_merge;
 	opts.src_index = &the_index;
 	opts.dst_index = &the_index;
-	setup_unpack_trees_porcelain(opts.msgs, "merge");
+	setup_unpack_trees_porcelain(&opts, "merge");
 
 	init_tree_desc_from_tree(t+0, common);
 	init_tree_desc_from_tree(t+1, head);
diff --git a/unpack-trees.c b/unpack-trees.c
index 4520aa0..17501d3 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -50,8 +50,10 @@ const char *unpack_plumbing_errors[NB_UNPACK_TREES_ERROR_TYPES] = {
 	  ? ((o)->msgs[(type)])      \
 	  : (unpack_plumbing_errors[(type)]) )
 
-void setup_unpack_trees_porcelain(const char **msgs, const char *cmd)
+void setup_unpack_trees_porcelain(struct unpack_trees_options *opts,
+				  const char *cmd)
 {
+	const char **msgs = opts->msgs;
 	const char *msg;
 	char *tmp;
 	const char *cmd2 = strcmp(cmd, "checkout") ? cmd : "switch branches";
diff --git a/unpack-trees.h b/unpack-trees.h
index d62bba9..fad680d 100644
--- a/unpack-trees.h
+++ b/unpack-trees.h
@@ -26,7 +26,8 @@ enum unpack_trees_error_types {
  * Sets the list of user-friendly error messages to be used by the
  * command "cmd" (either merge or checkout)
  */
-void setup_unpack_trees_porcelain(const char **msgs, const char *cmd);
+void setup_unpack_trees_porcelain(struct unpack_trees_options *opts,
+				  const char *cmd);
 
 struct rejected_paths_list {
 	char *path;
-- 
1.7.2.2.175.ga619d.dirty
Previous: Matthieu MoyNext: Matthieu Moy
Message 10 of 16 in “Re: [PATCH for next] insert missing newline in a diagnostic”
  1. Matthieu MoySep 1, 2010
  2. Make sure show_all_errors when using porcelain error messagesMatthieu Moy, Sep 1, 2010
  3. Junio C HamanoSep 1, 2010
  4. Matthieu MoySep 1, 2010
  5. Junio C HamanoSep 1, 2010
  6. 0/3 (hopefully) Proper fix to set show_all_errors where neededMatthieu Moy, Sep 2, 2010
  7. Jim MeyeringSep 3, 2010
  8. t7609-merge-co-error-msgs: test non-fast forward case too.Matthieu Moy, Sep 3, 2010
  9. 1/3 Move set_porcelain_error_msgs to unpack-trees.c and rename itMatthieu Moy, Sep 2, 2010
  10. 2/3 setup_unpack_trees_porcelain: take the whole options struct as parameterMatthieu Moy, Sep 2, 2010
  11. 3/3 Move "show_all_errors = 1" to setup_unpack_trees_porcelain()Matthieu Moy, Sep 2, 2010
  12. Junio C HamanoSep 2, 2010
  13. Matthieu MoySep 2, 2010
  14. Move "show_all_errors = 1" to setup_unpack_trees_porcelain()Matthieu Moy, Sep 2, 2010
  15. Jim MeyeringSep 2, 2010
  16. Matthieu MoySep 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.