[PATCH] for-each-ref: fix objectname:short bug
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Aug 26, 2010, 21:34 UTC
- Message-ID
- <1282858469-22116-1-git-send-email-jaysoffian@gmail.com>
- In-Reply-To
- <AANLkTikhcAC6Nf=jWQN40ascodaCte6v6e1JPfv-=To-@mail.gmail.com>
When objectname:short was introduced, it forgot to copy the result of find_unique_abbrev. Because the result of find_unique_abbrev is a pointer to static buffer, this resulted in the same value being substituted in for each ref.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com> --- builtin/for-each-ref.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c index a2b28c6..89e75c6 100644 --- a/builtin/for-each-ref.c +++ b/builtin/for-each-ref.c @@ -228,7 +228,8 @@ static void grab_common_values(struct atom_value *val, int deref, struct object v->s = s; } else if (!strcmp(name, "objectname:short")) { - v->s = find_unique_abbrev(obj->sha1, DEFAULT_ABBREV); + v->s = xstrdup(find_unique_abbrev(obj->sha1, + DEFAULT_ABBREV)); } } }
-- 1.7.2.2.170.gb30b3d