git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH (resend)] post-receive-email: remove spurious commas in email subject

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Aug 11, 2010, 08:14 UTC
Message-ID
<1281514453-23855-1-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<4C581E98.6090504@digium.com>
The previous form produced subjects like
  [SCM] project.git branch, foo, updated. ...
The new one will produce the lighter
  [SCM] project.git branch foo updated. ...
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
"Kevin P. Fleming" <kpfleming@digium.com> writes:
Show 7 quoted lines
> On 08/03/2010 08:10 AM, Matthieu Moy wrote:
>
>> I am the only one bothered by these extra commas in email subject? If
>> so, I can live with it, but I thought I'd give it a try ;-).
>
> No, I've removed them in our local copy as well, but never bothered to
> send the changes to the list :-)
I guess it's time to get this into git.git then ...
 contrib/hooks/post-receive-email |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 30ae63d..09c5241 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -203,7 +203,7 @@ generate_email_header()
 	# Generate header
 	cat <<-EOF
 	To: $recipients
-	Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
+	Subject: ${emailprefix}$projectdesc $refname_type $short_refname ${change_type}d. $describe
 	X-Git-Refname: $refname
 	X-Git-Reftype: $refname_type
 	X-Git-Oldrev: $oldrev
-- 
1.7.2.1.52.g95e25.dirty
Previous: Kevin P. Fleming
Message 3 of 3 in “post-receive-email: remove spurious commas in email subject.”
  1. post-receive-email: remove spurious commas in email subject.Matthieu Moy, Aug 3, 2010
  2. Kevin P. FlemingAug 3, 2010
  3. post-receive-email: remove spurious commas in email subjectMatthieu Moy, Aug 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.