git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/5 v3] log and diff: accept detached forms (--option value)

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Jul 29, 2010, 08:20 UTC
Message-ID
<1280391629-30017-1-git-send-email-Matthieu.Moy@imag.fr>
Since last version :
* I had missed several optional arguments, for which detached form
  should not be allowed (otherwise, --option --other-option is
  ambiguous). In most cases, my changes were harmless since the code
  had already checked for the parameterless form before reaching mine,
  but that was definitely bad anyway.
* One missing "return optarg;" (that even Jonathan had missed ;-) )
* One more test for "git log -S" failure (no argument to -S)
* Refactoring by Jonathan Nieder for --stat-*
* Rewording of commit messages.
Jonathan Nieder (1):
  diff: split off a function for --stat-* option parsing
Matthieu Moy (4):
  diff: parse detached options like -S foo
  diff: parse detached options --stat-width n, --stat-name-width n
  log: parse detached options like git log --grep foo
  log: parse detached option for --glob
 diff.c                       |  167 +++++++++++++++++++++++++++++++-----------
 diff.h                       |    7 ++
 revision.c                   |   79 +++++++++++++-------
 t/t4013-diff-various.sh      |    5 +
 t/t4013/diff.log_-S_F_master |    7 ++
 t/t4202-log.sh               |   19 +++--
 t/t6018-rev-list-glob.sh     |    6 ++
 7 files changed, 211 insertions(+), 79 deletions(-)
 create mode 100644 t/t4013/diff.log_-S_F_master
-- 
1.7.2.21.ge9796
Next: Matthieu Moy
Message 1 of 25 in “log and diff: accept detached forms (--option value)”
  1. 0/5 log and diff: accept detached forms (--option value)Matthieu Moy, Jul 29, 2010
  2. 1/5 diff: parse detached options like -S fooMatthieu Moy, Jul 29, 2010
  3. 2/5 diff: split off a function for --stat-* option parsingMatthieu Moy, Jul 29, 2010
  4. 3/5 diff: parse detached options --stat-width n, --stat-name-width nMatthieu Moy, Jul 29, 2010
  5. 4/5 log: parse detached options like git log --grep fooMatthieu Moy, Jul 29, 2010
  6. Jonathan NiederJul 29, 2010
  7. Matthieu MoyJul 30, 2010
  8. 1/5 diff: parse detached options like -S fooMatthieu Moy, Jul 30, 2010
  9. Junio C HamanoAug 2, 2010
  10. Matthieu MoyAug 2, 2010
  11. Jonathan NiederAug 2, 2010
  12. 2/5 diff: split off a function for --stat-* option parsingMatthieu Moy, Jul 30, 2010
  13. 3/5 diff: parse detached options --stat-width n, --stat-name-width nMatthieu Moy, Jul 30, 2010
  14. Junio C HamanoAug 2, 2010
  15. Matthieu MoyAug 2, 2010
  16. 4/5 log: parse detached options like git log --grep fooMatthieu Moy, Jul 30, 2010
  17. Junio C HamanoAug 2, 2010
  18. Matthieu MoyAug 2, 2010
  19. Junio C HamanoAug 2, 2010
  20. Matthieu MoyAug 3, 2010
  21. Junio C HamanoAug 3, 2010
  22. Matthieu MoyAug 3, 2010
  23. Miles BaderAug 4, 2010
  24. 5/5 log: parse detached option for --globMatthieu Moy, Jul 30, 2010
  25. 5/5 log: parse detached option for --globMatthieu Moy, Jul 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.