git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] vcs-svn: Remove stray calls to removed functions

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jul 29, 2010, 05:36 UTC
Message-ID
<1280381780-6265-2-git-send-email-artagnon@gmail.com>
In-Reply-To
<1280381780-6265-1-git-send-email-artagnon@gmail.com>

repo_tree.c makes calls to non-existant commit_init, dir_init and dirent_init functions, and string_pool.c makes a call to non-existant string_init function. These functions were previously generated in obj_pool.h before persistence in svn-fe was turned off.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 vcs-svn/repo_tree.c   |    3 ---
 vcs-svn/string_pool.c |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c
index c27d077..1ce184d 100644
--- a/vcs-svn/repo_tree.c
+++ b/vcs-svn/repo_tree.c
@@ -308,9 +308,6 @@ static void mark_init(void)
 
 void repo_init() {
 	pool_init();
-	commit_init();
-	dir_init();
-	dirent_init();
 	mark_init();
 	if (commit_pool.size == 0) {
 		/* Create empty tree for commit 0. */
diff --git a/vcs-svn/string_pool.c b/vcs-svn/string_pool.c
index bd5a380..616b17e 100644
--- a/vcs-svn/string_pool.c
+++ b/vcs-svn/string_pool.c
@@ -93,7 +93,6 @@ void pool_init(void)
 {
 	uint32_t node;
 	uint32_t string = 0;
-	string_init();
 	while (string < string_pool.size) {
 		node = node_alloc(1);
 		node_pointer(node)->offset = string;
-- 
1.7.1
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 2 of 4 in “svn-fe fixes”
  1. 0/3 svn-fe fixesRamkumar Ramachandra, Jul 29, 2010
  2. 1/3 vcs-svn: Remove stray calls to removed functionsRamkumar Ramachandra, Jul 29, 2010
  3. 2/3 contrib/svn-fe: Fix IncludePathRamkumar Ramachandra, Jul 29, 2010
  4. 3/3 contrib/svn-fe: Add the svn-fe target to .gitignoreRamkumar Ramachandra, Jul 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.