git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/7] Makefile: Include subdirectories in "make cover" reports

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 25, 2010, 14:40 UTC
Message-ID
<1280068861-17701-3-git-send-email-avarab@gmail.com>
In-Reply-To
<1280068861-17701-1-git-send-email-avarab@gmail.com>

We generate profiling files in all the $(OBJECTS) dirs. Aggregate results from there, and add them to the corresponding clean target.

Also expand the gcov arguments. Generate reports for things like "x()
|| y()" using --all-blocks, and add --preserve-paths since we're
profiling in subdirectories now.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index bc3c570..a95d260 100644
--- a/Makefile
+++ b/Makefile
@@ -2280,8 +2280,11 @@ coverage:
 	$(MAKE) coverage-build
 	$(MAKE) coverage-report
 
+object_dirs := $(sort $(dir $(OBJECTS)))
 coverage-clean:
-	rm -f *.gcda *.gcno
+	$(RM) $(addsuffix *.gcov,$(object_dirs))
+	$(RM) $(addsuffix *.gcda,$(object_dirs))
+	$(RM) $(addsuffix *.gcno,$(object_dirs))
 
 COVERAGE_CFLAGS = $(CFLAGS) -O0 -ftest-coverage -fprofile-arcs
 COVERAGE_LDFLAGS = $(CFLAGS)  -O0 -lgcov
@@ -2292,7 +2295,9 @@ coverage-build: coverage-clean
 		-j1 test
 
 coverage-report:
-	gcov -b *.c
+	for dir in $(object_dirs); do \
+		gcov --preserve-paths --branch-probabilities --all-blocks --object-directory=$$dir $$dir*.c; \
+	done
 	grep '^function.*called 0 ' *.c.gcov \
 		| sed -e 's/\([^:]*\)\.gcov: *function \([^ ]*\) called.*/\1: \2/' \
 		| tee coverage-untested-functions
-- 
1.7.0.4
Previous: Jonathan NiederNext: Jonathan Nieder
Message 4 of 17 in “Detailed test coverage reports for Git”
  1. 0/7 Detailed test coverage reports for GitÆvar Arnfjörð Bjarmason, Jul 25, 2010
  2. 1/7 gitignore: Ignore files generated by "make coverage"Ævar Arnfjörð Bjarmason, Jul 25, 2010
  3. Jonathan NiederJul 25, 2010
  4. 2/7 Makefile: Include subdirectories in "make cover" reportsÆvar Arnfjörð Bjarmason, Jul 25, 2010
  5. Jonathan NiederJul 25, 2010
  6. 3/7 Makefile: Split out the untested functions targetÆvar Arnfjörð Bjarmason, Jul 25, 2010
  7. 4/7 Makefile: Add coverage-report-cover-db targetÆvar Arnfjörð Bjarmason, Jul 25, 2010
  8. Jonathan NiederJul 25, 2010
  9. 5/7 Makefile: Add coverage-report-cover-db-html targetÆvar Arnfjörð Bjarmason, Jul 25, 2010
  10. Jonathan NiederJul 25, 2010
  11. 6/7 t/README: A new section about test coverageÆvar Arnfjörð Bjarmason, Jul 25, 2010
  12. 7/7 t/README: Add a note about the dangers of coverage chasingÆvar Arnfjörð Bjarmason, Jul 25, 2010
  13. Jonathan NiederJul 25, 2010
  14. Ævar Arnfjörð BjarmasonJul 25, 2010
  15. Jonathan NiederJul 25, 2010
  16. Ævar Arnfjörð BjarmasonJul 25, 2010
  17. Jonathan NiederJul 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.