[PATCHv2 5/5] fast-import: Fix minor data-loss issue with directories becoming symlinks
- From
newren@gmail.com <newren@gmail.com>
- Date
- Jul 6, 2010, 18:51 UTC
- Message-ID
- <1278442295-23033-6-git-send-email-newren@gmail.com>
- In-Reply-To
- <1278442295-23033-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>
When fast-export runs across a directory changing to a symlink, it will output the changes in the form M 120000 :239821 dir-changing-to-symlink D dir-changing-to-symlink/filename1 When fast-import sees the first line, it deletes the directory named dir-changing-to-symlink (and any files below it) and creates a symlink in its place. When fast-import came across the second line, it was previously trying to remove the file and relevant leading directories in tree_content_remove(), and as a side effect it would delete the symlink that was just created. This resulted in the symlink silently missing from the resulting repository.
We fix this by ignoring file deletions underneath directory names that correspond to symlinks. This can also be viewed as a minor optimization: since there cannot be a symlink and a directory with the same name in the same directory, the file clearly can't exist so nothing needs to be done to delete it.
Signed-off-by: Elijah Newren <newren@gmail.com> --- fast-import.c | 5 +++++ t/t9350-fast-export.sh | 2 +- 2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/fast-import.c b/fast-import.c index 309f2c5..10462d8 100644 --- a/fast-import.c +++ b/fast-import.c @@ -1528,6 +1528,11 @@ static int tree_content_remove( for (i = 0; i < t->entry_count; i++) { e = t->entries[i]; if (e->name->str_len == n && !strncmp(p, e->name->str_dat, n)) { + if (slash1 && S_ISLNK(e->versions[1].mode)) + /* If a parent directory of p is a symlink, then + * p cannot exist and need not be deleted. + */ + return 1; if (!slash1 || !S_ISDIR(e->versions[1].mode)) goto del_entry; if (!e->tree) diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh index 69179c6..1ee1461 100755 --- a/t/t9350-fast-export.sh +++ b/t/t9350-fast-export.sh @@ -376,7 +376,7 @@ test_expect_success 'tree_tag-obj' 'git fast-export tree_tag-obj' test_expect_success 'tag-obj_tag' 'git fast-export tag-obj_tag' test_expect_success 'tag-obj_tag-obj' 'git fast-export tag-obj_tag-obj' -test_expect_failure 'directory becomes symlink' ' +test_expect_success 'directory becomes symlink' ' git init dirtosymlink && git init result && (
-- 1.7.1.1.6.gc3cd6