git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: remove redundant munging of @@INSTLIBDIR@@

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
May 30, 2010, 17:12 UTC
Message-ID
<1275239561-31437-1-git-send-email-avarab@gmail.com>

Junio originally added this in f6276fe159 for use in `unshift @INC, '@@INSTLIBDIR@@'' in git-fmt-merge-msg.perl. That program was since then rewritten in C in 00449f992b. And since 6fcca938b0 all Perl programs use `use lib' to set their @INC path.

There's been no @@INSTLIBDIR@@ in any Perl script to replace since then. So there's no reason to keep it around.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

I saw this when doing Perl/Gettext support. @@INSTLIBDIR@@ hasn't been used for anything but the 'use lib' line there since mid-2006.

 Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index d5d6565..64e30db 100644
--- a/Makefile
+++ b/Makefile
@@ -1562,11 +1562,10 @@ $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
 	sed -e '1{' \
 	    -e '	s|#!.*perl|#!$(PERL_PATH_SQ)|' \
 	    -e '	h' \
-	    -e '	s=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || "@@INSTLIBDIR@@"));=' \
+	    -e '	s=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || "'"$$INSTLIBDIR"'"));=' \
 	    -e '	H' \
 	    -e '	x' \
 	    -e '}' \
-	    -e 's|@@INSTLIBDIR@@|'"$$INSTLIBDIR"'|g' \
 	    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
 	    $@.perl >$@+ && \
 	chmod +x $@+ && \
-- 
1.7.1.237.gf48e9
Message 1 of 1 in “Makefile: remove redundant munging of @@INSTLIBDIR@@”
  1. Makefile: remove redundant munging of @@INSTLIBDIR@@Ævar Arnfjörð Bjarmason, May 30, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.