Re: Apology/Bug report: git-send-email sends everything on Ctrl+C

From: Will Palmer <wmpalmer@gmail.com>
Date: May 26, 2010, 08:05 UTC
Message-ID: <1274861112.2074.2.camel@wpalmer.simply-domain>
In-Reply-To: <4BFCC4B5.6070408@vilain.net>

On Wed, 2010-05-26 at 18:50 +1200, Sam Vilain wrote:

Show 16 quoted lines

> Sam Vilain wrote:
> > Expect a mail storm shortly, sorry folks.
> >   
> 
> I just had a look at patching git-send-email.perl; but it looks like it
> is checking $? correctly at least since beece9da;
> 
>             system('sh', '-c', $editor.' "$@"', $editor, $_);
>             if (($? & 127) || ($? >> 8)) {
>                 die("the editor exited uncleanly, aborting everything");
>             }
> 
> I think I must have actually hit Ctrl-Z, not Ctrl-C.  So, it's all my
> fault and I apologize profusely.
> 
> Sam

I'd consider anything that can make "accidentally sending 100+ patches" possible to be a bug. How does "it was Ctrl-Z, not Ctrl-C" make a difference here?