git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] clone: also configure url for bare clones

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Mar 29, 2010, 16:48 UTC
Message-ID
<1269881309-19690-3-git-send-email-srabbelier@gmail.com>
In-Reply-To
<1269881309-19690-1-git-send-email-srabbelier@gmail.com>

Without this the 'origin' remote would not be configured, so when calling remote_get with 'origin' as argument we would get an unconfigured remote. ---

	Turns out there was one use-case that is not exercised by the
	test suite. The remote-helper tests later in the series do
	exercised that path, but we might want a seperate test.
 builtin/clone.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 068d61f..05be999 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -495,12 +495,12 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 			git_config_set(key.buf, "true");
 			strbuf_reset(&key);
 		}
-
-		strbuf_addf(&key, "remote.%s.url", option_origin);
-		git_config_set(key.buf, repo);
-		strbuf_reset(&key);
 	}
 
+	strbuf_addf(&key, "remote.%s.url", option_origin);
+	git_config_set(key.buf, repo);
+	strbuf_reset(&key);
+
 	if (option_reference)
 		setup_reference(git_dir);
 
-- 
1.7.0.3.317.gbb04ec
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 3 of 14 in “remote-helpers: exporting”
  1. 0/7 remote-helpers: exportingSverre Rabbelier, Mar 29, 2010
  2. 1/7 clone: pass the remote name to remote_getSverre Rabbelier, Mar 29, 2010
  3. 2/7 clone: also configure url for bare clonesSverre Rabbelier, Mar 29, 2010
  4. 3/7 fast-import: always create marks_file directoriesSverre Rabbelier, Mar 29, 2010
  5. 4/7 remote-helpers: allow requesing the path to the .git directorySverre Rabbelier, Mar 29, 2010
  6. 5/7 remote-helpers: add support for an export commandSverre Rabbelier, Mar 29, 2010
  7. Daniel BarkalowMar 29, 2010
  8. Sverre RabbelierMar 29, 2010
  9. Junio C HamanoApr 1, 2010
  10. Sverre RabbelierApr 1, 2010
  11. 6/7 remote-helpers: add testgit helperSverre Rabbelier, Mar 29, 2010
  12. 7/7 remote-helpers: add tests for testgit helperSverre Rabbelier, Mar 29, 2010
  13. Jonathan NiederApr 12, 2010
  14. Sverre RabbelierApr 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.