git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 00/19] nd/setup part two, second round

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 21, 2010, 10:30 UTC
Message-ID
<1269167446-7799-1-git-send-email-pclouds@gmail.com>

Again, this series is to make repository setup more predictable, i.e. must be done in either setup_git_dir*, enter_repo or init_db. Compared to the first version [1]:

 - More detail in commit messages, mostly extracted from [2]
 - Fix "git foo -h" code path (that skips repo setup) in patches 14-16

[1] http://mid.gmane.org/1268313754-28179-1-git-send-email-pclouds@gmail.com [2] http://mid.gmane.org/fcaeb9bf1003200110w721903e7v7a5823cb312cbc71@mail.gmail.com

Nguyễn Thái Ngọc Duy (19):
  Move enter_repo() to setup.c
  enter_repo(): initialize other variables as setup_git_directory_gently() does
  rev-parse --git-dir: print relative gitdir correctly
  worktree setup: call set_git_dir explicitly
  Add git_config_early()
  Use git_config_early() instead of git_config() during repo setup
  worktree setup: restore original state when things go wrong
  init/clone: turn on startup->have_repository properly
  git_config(): do not read .git/config if there is no repository
  Do not read .git/info/exclude if there is no repository
  Do not read .git/info/attributes if there is no repository
  apply: do not check sha1 when repository has not been found
  config: do not read .git/config if there is no repository
  run_builtin(): save "-h" detection result for later use
  builtins: utilize startup_info->help where possible
  builtins: check for startup_info->help, print and exit early
  Allow to undo setup_git_directory_gently() gracefully (and fix alias code)
  alias: keep repository found while collecting aliases as long as possible
  Guard unallowed access to repository when it's not set up
 attr.c                     |    5 +-
 builtin/apply.c            |    2 +-
 builtin/branch.c           |    3 +
 builtin/check-ref-format.c |    2 +-
 builtin/checkout-index.c   |    3 +
 builtin/clone.c            |    3 +-
 builtin/commit.c           |    6 ++
 builtin/config.c           |    9 ++-
 builtin/gc.c               |    3 +
 builtin/grep.c             |    2 +-
 builtin/index-pack.c       |    2 +-
 builtin/init-db.c          |   10 ++-
 builtin/log.c              |    7 +-
 builtin/ls-files.c         |    3 +
 builtin/merge-ours.c       |    2 +-
 builtin/merge.c            |    3 +
 builtin/pack-redundant.c   |    2 +-
 builtin/rev-parse.c        |    8 ++
 builtin/show-ref.c         |    2 +-
 builtin/update-index.c     |    3 +
 builtin/upload-archive.c   |    7 +-
 cache.h                    |    7 ++-
 config.c                   |   22 ++++-
 dir.c                      |    8 +-
 environment.c              |   33 +++++++-
 git.c                      |   33 +++++---
 path.c                     |   91 ---------------------
 setup.c                    |  191 +++++++++++++++++++++++++++++++++++++++++---
 t/t1300-repo-config.sh     |   14 +++
 t/t1302-repo-version.sh    |    2 +-
 t/t7002-grep.sh            |   24 ++++++
 31 files changed, 360 insertions(+), 152 deletions(-)
Next: Nguyễn Thái Ngọc Duy
Message 1 of 20 in “nd/setup part two, second round”
  1. 00/19 nd/setup part two, second roundNguyễn Thái Ngọc Duy, Mar 21, 2010
  2. 01/19 Move enter_repo() to setup.cNguyễn Thái Ngọc Duy, Mar 21, 2010
  3. 02/19 enter_repo(): initialize other variables as setup_git_directory_gently() doesNguyễn Thái Ngọc Duy, Mar 21, 2010
  4. 03/19 rev-parse --git-dir: print relative gitdir correctlyNguyễn Thái Ngọc Duy, Mar 21, 2010
  5. 04/19 worktree setup: call set_git_dir explicitlyNguyễn Thái Ngọc Duy, Mar 21, 2010
  6. 05/19 Add git_config_early()Nguyễn Thái Ngọc Duy, Mar 21, 2010
  7. 06/19 Use git_config_early() instead of git_config() during repo setupNguyễn Thái Ngọc Duy, Mar 21, 2010
  8. 07/19 worktree setup: restore original state when things go wrongNguyễn Thái Ngọc Duy, Mar 21, 2010
  9. 08/19 init/clone: turn on startup->have_repository properlyNguyễn Thái Ngọc Duy, Mar 21, 2010
  10. 09/19 git_config(): do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Mar 21, 2010
  11. 10/19 Do not read .git/info/exclude if there is no repositoryNguyễn Thái Ngọc Duy, Mar 21, 2010
  12. 11/19 Do not read .git/info/attributes if there is no repositoryNguyễn Thái Ngọc Duy, Mar 21, 2010
  13. 12/19 apply: do not check sha1 when repository has not been foundNguyễn Thái Ngọc Duy, Mar 21, 2010
  14. 13/19 config: do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Mar 21, 2010
  15. 14/19 run_builtin(): save "-h" detection result for later useNguyễn Thái Ngọc Duy, Mar 21, 2010
  16. 15/19 builtins: utilize startup_info->help where possibleNguyễn Thái Ngọc Duy, Mar 21, 2010
  17. 16/19 builtins: check for startup_info->help, print and exit earlyNguyễn Thái Ngọc Duy, Mar 21, 2010
  18. 17/19 Allow to undo setup_git_directory_gently() gracefully (and fix alias code)Nguyễn Thái Ngọc Duy, Mar 21, 2010
  19. 18/19 alias: keep repository found while collecting aliases as long as possibleNguyễn Thái Ngọc Duy, Mar 21, 2010
  20. 19/19 Guard unallowed access to repository when it's not set upNguyễn Thái Ngọc Duy, Mar 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.